From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from smtp.citrix.com ([66.165.176.89]:1499 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751492AbbH0RVt (ORCPT <rfc822;stable@vger.kernel.org>);
	Thu, 27 Aug 2015 13:21:49 -0400
Message-ID: <55DF4729.50205@citrix.com>
Date: Thu, 27 Aug 2015 18:21:45 +0100
From: David Vrabel <david.vrabel@citrix.com>
MIME-Version: 1.0
To: =?UTF-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>,
	Sasha Levin <sasha.levin@oracle.com>
CC: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Re: [added to the 3.18 stable tree] xen/gntdevt: Fix race condition
 in gntdev_release()
References: <1440689954-10813-1-git-send-email-sasha.levin@oracle.com>
 <1440689954-10813-26-git-send-email-sasha.levin@oracle.com>
 <20150827171512.GV1345@mail-itl>
In-Reply-To: <20150827171512.GV1345@mail-itl>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 27/08/15 18:15, Marek Marczykowski-Górecki wrote:
> On Thu, Aug 27, 2015 at 11:37:44AM -0400, Sasha Levin wrote:
>> From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>>
>> This patch has been added to the 3.18 stable tree. If you have any
>> objections, please let us know.
> 
> On 3.18 it should be spin_lock, not mutex_lock.
> Modified patch here:
> https://raw.githubusercontent.com/QubesOS/qubes-linux-kernel/stable-3.18/patches.xen/0001-xen-grant-fix-race-condition-in-gntdev_release.patch

No.  Because this results in a sleep while holding the spin lock (in
free_xenballooned_pages()).

1401c00e59ea021c575f74612fe2dbba36d6a4ee (xen/gntdev: convert priv->lock
to a mutex) is a prerequisite.

David