From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from userp1040.oracle.com ([156.151.31.81]:44345 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752636AbbH0RZ5 (ORCPT
	<rfc822;stable@vger.kernel.org>); Thu, 27 Aug 2015 13:25:57 -0400
Message-ID: <55DF481F.5000208@oracle.com>
Date: Thu, 27 Aug 2015 13:25:51 -0400
From: Sasha Levin <sasha.levin@oracle.com>
MIME-Version: 1.0
To: David Vrabel <david.vrabel@citrix.com>,
	=?UTF-8?B?TWFyZWsgTWFyY3p5a293?= =?UTF-8?B?c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
CC: stable@vger.kernel.org, stable-commits@vger.kernel.org
Subject: Re: [added to the 3.18 stable tree] xen/gntdevt: Fix race condition
 in gntdev_release()
References: <1440689954-10813-1-git-send-email-sasha.levin@oracle.com> <1440689954-10813-26-git-send-email-sasha.levin@oracle.com> <20150827171512.GV1345@mail-itl> <55DF4729.50205@citrix.com>
In-Reply-To: <55DF4729.50205@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 08/27/2015 01:21 PM, David Vrabel wrote:
> On 27/08/15 18:15, Marek Marczykowski-Górecki wrote:
>> > On Thu, Aug 27, 2015 at 11:37:44AM -0400, Sasha Levin wrote:
>>> >> From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>>> >>
>>> >> This patch has been added to the 3.18 stable tree. If you have any
>>> >> objections, please let us know.
>> > 
>> > On 3.18 it should be spin_lock, not mutex_lock.
>> > Modified patch here:
>> > https://raw.githubusercontent.com/QubesOS/qubes-linux-kernel/stable-3.18/patches.xen/0001-xen-grant-fix-race-condition-in-gntdev_release.patch
> No.  Because this results in a sleep while holding the spin lock (in
> free_xenballooned_pages()).
> 
> 1401c00e59ea021c575f74612fe2dbba36d6a4ee (xen/gntdev: convert priv->lock
> to a mutex) is a prerequisite.

Thanks! I've grabbed 1401c00e59e and re-pushed the queue.


Thanks,
Sasha