From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/radeon/native: Send out the full AUX address
Date: Mon, 31 Aug 2015 17:25:09 +0200 [thread overview]
Message-ID: <55E471D5.3020807@vodafone.de> (raw)
In-Reply-To: <1441034343-20809-1-git-send-email-alexander.deucher@amd.com>
On 31.08.2015 17:19, Alex Deucher wrote:
> AUX addresses are 20 bits long. Send out the entire address instead of
> just the low 16 bits.
>
> Port of:
> drm/radeon/atom: Send out the full AUX address
> to radeon non-atom aux path
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Christian König <christian.koenig@amd.com> for both patches.
> ---
> drivers/gpu/drm/radeon/radeon_dp_auxch.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> index fcbd60b..3b0c229 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> @@ -116,8 +116,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
> AUX_SW_WR_BYTES(bytes));
>
> /* write the data header into the registers */
> - /* request, addres, msg size */
> - byte = (msg->request << 4);
> + /* request, address, msg size */
> + byte = (msg->request << 4) | ((msg->address >> 16) & 0xf);
> WREG32(AUX_SW_DATA + aux_offset[instance],
> AUX_SW_DATA_MASK(byte) | AUX_SW_AUTOINCREMENT_DISABLE);
>
prev parent reply other threads:[~2015-08-31 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 15:19 [PATCH 1/2] drm/radeon/native: Send out the full AUX address Alex Deucher
2015-08-31 15:19 ` [PATCH 2/2] drm/amdgpu/atom: " Alex Deucher
2015-09-01 3:44 ` Zhou, Jammy
2015-09-01 4:03 ` Alex Deucher
2015-08-31 15:25 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E471D5.3020807@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).