From: Zefan Li <lizefan@huawei.com>
To: Dirk Behme <dirk.behme@gmail.com>
Cc: stable <stable@vger.kernel.org>
Subject: Re: 3.4.106: futex: Wrong back port of 9e9aab5dbf?
Date: Mon, 7 Sep 2015 16:43:40 +0800 [thread overview]
Message-ID: <55ED4E3C.7000101@huawei.com> (raw)
In-Reply-To: <55C59DDE.5020908@gmail.com>
Hi Dirk,
On 2015/8/8 14:12, Dirk Behme wrote:
> Hello,
>
> from a private -stable review we think that the commit 9e9aab5dbf ("futex: Ensure get_futex_key_refs() always implies a barrier" [1]) is not correctly back ported to 3.4.x:
>
> The issue is that the memory barrier is introduced into drop_futex_key_refs() function instead of get_futex_key_refs() function.
>
> Additionally, we are unsure if the futex commits this commit is fixing are really in < 3.4.106. I.e. we are unsure if this fix is needed at all. Or at least if some additional futex commits are needed.
>
> Do you like to check?
>
I've confired this commit isn't needed for 3.4.y. It was backported quite long ago,
and at that time I hadn't improved my scripts to check the Fixes tag. Fortunately
seems this mistake won't cause serious issue.
I'll revert it in the coming 3.4.109. Thanks for the review!
prev parent reply other threads:[~2015-09-07 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 6:12 3.4.106: futex: Wrong back port of 9e9aab5dbf? Dirk Behme
2015-09-07 8:43 ` Zefan Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED4E3C.7000101@huawei.com \
--to=lizefan@huawei.com \
--cc=dirk.behme@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).