From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-la0-f45.google.com ([209.85.215.45]:33710 "EHLO
	mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751098AbbIGVYd (ORCPT
	<rfc822;stable@vger.kernel.org>); Mon, 7 Sep 2015 17:24:33 -0400
Received: by lamp12 with SMTP id p12so56277254lam.0
        for <stable@vger.kernel.org>; Mon, 07 Sep 2015 14:24:32 -0700 (PDT)
Subject: Re: [PATCH v2] stmmac: fix check for phydev being open
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	netdev@vger.kernel.org
References: <1441659019-25522-1-git-send-email-abrodkin@synopsys.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	David Miller <davem@davemloft.net>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <55EE008E.6040405@cogentembedded.com>
Date: Tue, 8 Sep 2015 00:24:30 +0300
MIME-Version: 1.0
In-Reply-To: <1441659019-25522-1-git-send-email-abrodkin@synopsys.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 09/07/2015 11:50 PM, Alexey Brodkin wrote:

> Current implementation via IS_ERR(phydev) may make no sense because
> of_phy_attach() returns NULL on failure instead of error value.

    Not of_phy_connect()?

> Still for checking result of phy_connect() IS_ERR() is useful.
>
> To address both situations we use combined IS_ERR_OR_NULL() check.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <davem@davemloft.net>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

MBR, Sergei