From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:46858 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbbINPqb (ORCPT ); Mon, 14 Sep 2015 11:46:31 -0400 Message-ID: <55F6EBD4.30809@arm.com> Date: Mon, 14 Sep 2015 16:46:28 +0100 From: Marc Zyngier MIME-Version: 1.0 To: Will Deacon , kvmarm@lists.cs.columbia.edu CC: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux@arm.linux.org.uk, christoffer.dall@linaro.org, stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523 References: <1442243163-2675-1-git-send-email-will.deacon@arm.com> In-Reply-To: <1442243163-2675-1-git-send-email-will.deacon@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 14/09/15 16:06, Will Deacon wrote: > When restoring the system register state for an AArch32 guest at EL2, > writes to DACR32_EL2 may not be correctly synchronised by Cortex-A57, > which can lead to the guest effectively running with junk in the DACR > and running into unexpected domain faults. > > This patch works around the issue by re-ordering our restoration of the > AArch32 register aliases so that they happen before the AArch64 system > registers. Ensuring that the registers are restored in this order > guarantees that they will be correctly synchronised by the core. > > Cc: > Cc: Marc Zyngier > Signed-off-by: Will Deacon Reviewed-by: Marc Zyngier I'll queue that together with the next batch of fixes. Thanks, M. -- Jazz is not dead. It just smells funny...