From: Tero Kristo <t-kristo@ti.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Ben Dooks <ben.dooks@codethink.co.uk>
Cc: <linux-kernel@lists.codethink.co.uk>, <stable@vger.kernel.org>,
<mturquette@baylibre.com>, <linux-clk@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] clk: ti: fix dual-registration of uart4_ick
Date: Fri, 2 Oct 2015 09:07:19 +0300 [thread overview]
Message-ID: <560E1F17.9060609@ti.com> (raw)
In-Reply-To: <20151002001539.GA12338@codeaurora.org>
On 10/02/2015 03:15 AM, Stephen Boyd wrote:
> On 09/29, Ben Dooks wrote:
>> On the OMAP AM3517 platform the uart4_ick gets registered
>> twice, causing any power managment to /dev/ttyO3 to fail
>> when trying to wake the device up.
>>
>> This solves the following oops:
>>
>> [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008
>> [] PC is at serial_omap_pm+0x48/0x15c
>> [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c
>>
>> Cc: stable@vger.kernel.org
>> Cc: mturquette@baylibre.com
>> Cc: sboyd@codeaurora.org
>> Cc: linux-clk@vger.kernel.org
>> Cc: linux-omap@vger.kernel.org
>> Cc: t-kristo@ti.com
>> Cc: linux-kernel@lists.codethink.co.uk
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> Which patch broke this? Adding a Fixes: line will help us figure
> out where to backport this.
>
The issue has been around since the legacy clock data code already, I am
not quite sure which initially broke it though. As such, we can use the
initial clock conversion commit as a fixes by for this:
commit aafd900cab87d339dc3004c241eebc854005124b
Author: Tero Kristo <t-kristo@ti.com>
Date: Fri Aug 2 14:04:19 2013 +0300
CLK: TI: add omap3 clock init file
I'll add a fixes tag to this and queue it for 4.3-rc-fixes.
-Tero
next prev parent reply other threads:[~2015-10-02 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 14:01 [PATCH v2] clk: ti: fix dual-registration of uart4_ick Ben Dooks
2015-10-02 0:15 ` Stephen Boyd
2015-10-02 6:07 ` Tero Kristo [this message]
2015-10-02 17:31 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E1F17.9060609@ti.com \
--to=t-kristo@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).