From: roopa <roopa@cumulusnetworks.com>
To: Roland Dreier <roland@purestorage.com>
Cc: David Miller <davem@davemloft.net>,
tgraf@suug.ch, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
wkok@cumulusnetworks.com, stable@vger.kernel.org
Subject: Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs
Date: Fri, 02 Oct 2015 10:44:22 -0700 [thread overview]
Message-ID: <560EC276.3030905@cumulusnetworks.com> (raw)
In-Reply-To: <CAL1RGDWBJr=D3sRyZTM4VxrPf+Dy35K1DRYCZW9OZSkbtZPhww@mail.gmail.com>
On 10/2/15, 10:18 AM, Roland Dreier wrote:
> On Tue, Sep 22, 2015 at 9:40 PM, Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
>> + err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid,
>> + cb->nlh->nlmsg_seq, RTM_NEWRULE,
>> + NLM_F_MULTI, ops);
>> + if (err)
> FWIW I believe this breaks pre-4.0 stable kernels (unfortunately it
> just showed up in 3.10.90). In kernels without 053c095a82cf
> ("netlink: make nlmsg_end() and genlmsg_end() void") then
> fib_nl_fill_rule() returns a positive value (skb->len) on success, so
> we break out of the loop here immediately. Symptom is "ip rule show"
> loops forever printing the first rule.
>
> After I finish testing a fix (as trivial as changing to "if (err <
> 0)") here, I'll send it to -stable guys.
>
Thanks for catching this.
prev parent reply other threads:[~2015-10-02 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442983222-42750-1-git-send-email-roopa@cumulusnetworks.com>
2015-10-02 17:18 ` [PATCH net] fib_rules: fix fib rule dumps across multiple skbs Roland Dreier
2015-10-02 17:44 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560EC276.3030905@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roland@purestorage.com \
--cc=stable@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).