From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-am1on0087.outbound.protection.outlook.com ([157.56.112.87]:19632 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750812AbbJFF6p (ORCPT ); Tue, 6 Oct 2015 01:58:45 -0400 Subject: Re: [PATCH 3.2] IB/qib: Change lkey table allocation to support more MRs To: "Marciniszyn, Mike" , "stable@vger.kernel.org" References: <20150929145143.27497.86046.stgit@phlsvslse11.ph.intel.com> <560B933D.7020605@mellanox.com> <32E1700B9017364D9B60AED9960492BC257D8BB0@fmsmsx120.amr.corp.intel.com> CC: "linux-rdma@vger.kernel.org" From: Haggai Eran Message-ID: <561362ED.9000105@mellanox.com> Date: Tue, 6 Oct 2015 08:58:05 +0300 MIME-Version: 1.0 In-Reply-To: <32E1700B9017364D9B60AED9960492BC257D8BB0@fmsmsx120.amr.corp.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 02/10/2015 16:10, Marciniszyn, Mike wrote: >>> The lkey table is allocated with with a get_user_pages() with an >> Don't you mean __get_free_pages? >> > > I was a nit in the original upstream commit. > > I don’t think it is a big deal since the patch context clarifies. I agree it's not a big deal. I guess it only caught my attention since reading it made me wonder why you need pinned user memory for the lkey table. Haggai