From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:37111 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbbJGJ3j (ORCPT ); Wed, 7 Oct 2015 05:29:39 -0400 Subject: Re: [PATCH 2/2] KVM: x86: fix edge EOI and IOAPIC reconfig race To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org References: <1439473570-13763-1-git-send-email-rkrcmar@redhat.com> <1439473570-13763-3-git-send-email-rkrcmar@redhat.com> Cc: kvm@vger.kernel.org, Steve Rutherford , stable@vger.kernel.org From: Paolo Bonzini Message-ID: <5614E5FC.7060207@redhat.com> Date: Wed, 7 Oct 2015 11:29:32 +0200 MIME-Version: 1.0 In-Reply-To: <1439473570-13763-3-git-send-email-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 13/08/2015 15:46, Radim Krčmář wrote: > + if (kvm_x86_ops->sync_pir_to_irr(vcpu)) > + kvm_make_request(KVM_REQ_EVENT, vcpu); > + The call to sync_pir_to_irr belongs more in vcpu_scan_ioapic, I think. More importantly, I think that KVM_REQ_EVENT is a latent bug for kvm_vcpu_ioctl_get_lapic as well, so the call to kvm_make_request should go in vmx_sync_pir_to_irr or in a new kvm_sync_pir_to_irr wrapper. > + (e->fields.trig_mode == IOAPIC_EDGE_TRIG && > + kvm_apic_pending_eoi(vcpu, e->fields.vector))) Should we test again here that kvm_irq_has_notifier(ioapic->kvm, KVM_IRQCHIP_IOAPIC, index), to avoid unnecessarily marking other edge-triggered interrupts? Paolo