From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com ([209.85.220.48]:33228 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbbJLNEh (ORCPT ); Mon, 12 Oct 2015 09:04:37 -0400 Subject: Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards To: Alim Akhtar , linux-samsung-soc@vger.kernel.org References: <1444653438-6532-1-git-send-email-alim.akhtar@samsung.com> Cc: k.kozlowski.k@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene@kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, stable@vger.kernel.org From: Krzysztof Kozlowski Message-ID: <561BAFE0.5070205@samsung.com> Date: Mon, 12 Oct 2015 22:04:32 +0900 MIME-Version: 1.0 In-Reply-To: <1444653438-6532-1-git-send-email-alim.akhtar@samsung.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: W dniu 12.10.2015 o 21:37, Alim Akhtar pisze: > Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"), > sound card detection is broken on peach boards and gives below errors: > > [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 > [ 3.634233] max98090 7-0010: use default 2.8v micbias > [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok > [ 3.645307] max98090 7-0010: Invalid master clock frequency > [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 > [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) > [ 3.664366] snow-audio: probe of sound failed with error -22 > > This patch adds missing assigned-clocks and assigned-clock-parents for > pmu_system_controller node which is used as "mclk" for audio codec. > > Signed-off-by: Alim Akhtar > Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards") > Cc: > --- > Changes since v1: > Addressed Krzysztof's review comments. Looks good, thanks! Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof