From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:34129 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932310AbbJMSLg (ORCPT ); Tue, 13 Oct 2015 14:11:36 -0400 Subject: Re: [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation To: balbi@ti.com References: <1442947223-13277-1-git-send-email-k.opasiak@samsung.com> <1442947223-13277-2-git-send-email-k.opasiak@samsung.com> <20150930161152.GG32625@saruman.tx.rr.com> <20150930161519.GH32625@saruman.tx.rr.com> Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, andrzej.p@samsung.com, stable@vger.kernel.org From: Krzysztof Opasiak Message-id: <561D4954.5060905@samsung.com> Date: Tue, 13 Oct 2015 20:11:32 +0200 MIME-version: 1.0 In-reply-to: <20150930161519.GH32625@saruman.tx.rr.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hi, On 09/30/2015 06:15 PM, Felipe Balbi wrote: > On Wed, Sep 30, 2015 at 11:11:52AM -0500, Felipe Balbi wrote: >> On Tue, Sep 22, 2015 at 08:40:23PM +0200, Krzysztof Opasiak wrote: >>> Since: >>> >>> commit e0857ce58e8658657f5f12fe25272b93cfeb16aa >> >> this should be something like: >> >> Since commit e0857ce58e86 (" .... ") >> >>> ("usb: gadget: loopback: don't queue requests to bogus endpoints") >>> >>> Loopback function is not realy working as that commit removed >>> all looping back logic. After that commit ep-out works like >>> /dev/null and ep-in works like /dev/zero. >>> >>> This commit fix this issue by allocating set of out requests >>> and set of in requests but each out req shares buffer with >>> one in req: >>> >>> out_req->buf ---> buf <--- in_req.buf >>> out_req->context <---> in_req.context >>> >>> The completion routine simply enqueue the suitable req in >>> an oposite direction. >>> >>> Cc: # 3.18+ >> >> missing Fixes: e0857ce58e86 ("...") >> >> I'll fix both while applying, but make sure to make this proper >> next time. > > actually fails to apply to v4.3-rc3, please rebase. > Sorry for my late response but I was out of office due to ELCE in Dublin. I managed to apply this series onto 4.3-rc5 without any conflicts. Would you like me to split this series into 2 separate one so you can apply only this commit and leave the first one for the next merge window? Best regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics