From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bl2on0066.outbound.protection.outlook.com ([65.55.169.66]:51104 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751329AbbJOSHR (ORCPT ); Thu, 15 Oct 2015 14:07:17 -0400 Subject: Re: [PATCH] IB/srp: Fix possible send queue overflow To: Sagi Grimberg , References: <1444901206-27462-1-git-send-email-sagig@mellanox.com> CC: Stable From: Bart Van Assche Message-ID: <561FC7B5.8010103@sandisk.com> Date: Thu, 15 Oct 2015 08:35:17 -0700 MIME-Version: 1.0 In-Reply-To: <1444901206-27462-1-git-send-email-sagig@mellanox.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 10/15/2015 02:26 AM, Sagi Grimberg wrote: > When using work request based memory registration (fast_reg) > we must reserve SQ entries for registration and invalidation > in addition to send operations. Each IO consumes 3 SQ entries > (registration, send, invalidation) so we need to allocate 3x > larger send-queue instead of 2x. > > Signed-off-by: Sagi Grimberg > CC: Stable > --- > drivers/infiniband/ulp/srp/ib_srp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index d00f819..43b07f7 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -488,7 +488,7 @@ static int srp_create_ch_ib(struct srp_rdma_ch *ch) > struct ib_qp *qp; > struct ib_fmr_pool *fmr_pool = NULL; > struct srp_fr_pool *fr_pool = NULL; > - const int m = 1 + dev->use_fast_reg; > + const int m = dev->use_fast_reg ? 3 : 1; > struct ib_cq_init_attr cq_attr = {}; > int ret; > Reviewed-by: Bart Van Assche