Re: [PATCH 4.1 00/46] 4.1.12-stable review

[Guenter Roeck <linux@roeck-us.net>]

On 10/23/2015 04:22 PM, Greg Kroah-Hartman wrote:
> On Fri, Oct 23, 2015 at 02:34:56PM -0600, Shuah Khan wrote:
>> On 10/23/2015 11:45 AM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 4.1.12 release.
>>> There are 46 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sun Oct 25 17:46:11 UTC 2015.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> 	kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.1.12-rc1.gz
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> I am seeing the following compile error (was seen in 4.2.4-rc1)
>>
>> In file included from include/uapi/linux/stddef.h:1:0,
>>                   from include/linux/stddef.h:4,
>>                   from ./include/uapi/linux/posix_types.h:4,
>>                   from include/uapi/linux/types.h:13,
>>                   from include/linux/types.h:5,
>>                   from include/uapi/linux/capability.h:16,
>>                   from include/linux/capability.h:15,
>>                   from include/linux/sched.h:15,
>>                   from drivers/xen/preempt.c:12:
>> drivers/xen/preempt.c: In function ‘xen_maybe_preempt_hcall’:
>> drivers/xen/preempt.c:34:11: error: too few arguments to function
>> ‘should_resched’
>>          && should_resched())) {
>>             ^
>> include/linux/compiler.h:164:42: note: in definition of macro ‘unlikely’
>>   # define unlikely(x) __builtin_expect(!!(x), 0)
>>                                            ^
>> In file included from include/linux/preempt.h:18:0,
>>                   from include/linux/spinlock.h:50,
>>                   from include/linux/seqlock.h:35,
>>                   from include/linux/time.h:5,
>>                   from include/uapi/linux/timex.h:56,
>>                   from include/linux/timex.h:56,
>>                   from include/linux/sched.h:19,
>>                   from drivers/xen/preempt.c:12:
>> ./arch/x86/include/asm/preempt.h:93:29: note: declared here
>>   static __always_inline bool should_resched(int preempt_offset)
>>                               ^
>> scripts/Makefile.build:258: recipe for target 'drivers/xen/preempt.o' failed
>> make[2]: *** [drivers/xen/preempt.o] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> scripts/Makefile.build:403: recipe for target 'drivers/xen' failed
>> make[1]: *** [drivers/xen] Error 2
>> Makefile:947: recipe for target 'drivers' failed
>> make: *** [drivers] Error 2
>
Also for powerpc:

arch/powerpc/kvm/book3s_hv.c: In function 'kvmppc_run_vcpu':
arch/powerpc/kvm/book3s_hv.c:2181:3: error: too few arguments to function 'should_resched'

[ Didn't we have that before ? ]

Guenter