From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qmail.e-mind.com ([188.94.192.40]:56416 "HELO qmail.e-mind.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754424AbbKMJNw (ORCPT ); Fri, 13 Nov 2015 04:13:52 -0500 Subject: Re: [PATCH 3.19.y-ckt 046/155] ASoC: sgtl5000: fix wrong register MIC_BIAS_VOLTAGE setup on probe To: Kamal Mostafa , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com References: <1447370309-357-1-git-send-email-kamal@canonical.com> <1447370309-357-47-git-send-email-kamal@canonical.com> Cc: Gianluca Renzi , Mark Brown From: gianluca Message-ID: <5645A83E.9060606@eurek.it> Date: Fri, 13 Nov 2015 10:07:10 +0100 MIME-Version: 1.0 In-Reply-To: <1447370309-357-47-git-send-email-kamal@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 11/13/2015 12:16 AM, Kamal Mostafa wrote: > 3.19.8-ckt10 -stable review patch. If anyone has any objections, please let me know. > yes, it should works. Please add the correct message in the device-tree probe for the micbias voltage too. Just to have the same behaviour. > ------------------ > > From: Gianluca Renzi > > commit e256da84a04ea31c3c215997c847609af224e8f4 upstream. > > Signed-off-by: Gianluca Renzi > Signed-off-by: Mark Brown > Signed-off-by: Kamal Mostafa > --- > sound/soc/codecs/sgtl5000.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > index 10d2415..d91790e 100644 > --- a/sound/soc/codecs/sgtl5000.c > +++ b/sound/soc/codecs/sgtl5000.c > @@ -1337,8 +1337,8 @@ static int sgtl5000_probe(struct snd_soc_codec *codec) > sgtl5000->micbias_resistor << SGTL5000_BIAS_R_SHIFT); > > snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL, > - SGTL5000_BIAS_R_MASK, > - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT); > + SGTL5000_BIAS_VOLT_MASK, > + sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT); > /* > * disable DAP > * TODO: > -- Eurek s.r.l. | Electronic Engineering | http://www.eurek.it via Celletta 8/B, 40026 Imola, Italy | Phone: +39-(0)542-609120 p.iva 00690621206 - c.f. 04020030377 | Fax: +39-(0)542-609212