Re: [PATCH for 3.10-stable] virtio-net: drop NETIF_F_FRAGLIST

[Jiri Slaby <jslaby@suse.cz>]

On 11/06/2015, 07:55 PM, Greg KH wrote:
> On Tue, Oct 27, 2015 at 01:50:53AM +0000, Sheng Yong wrote:
>> From: Jason Wang <jasowang@redhat.com>
>>
>> commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39 upstream.
>>
>> virtio declares support for NETIF_F_FRAGLIST, but assumes
>> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
>> always true with a fraglist.
>>
>> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
>> the sg array, leading to memory corruption.
>>
>> Drop NETIF_F_FRAGLIST so we only get what we can handle.
>>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> ---
>>  drivers/net/virtio_net.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This patch isn't in any stable tree, why just add it to 3.10?  What
> about all of the other ones?

This was now submitted by David in NETWORKING patches for >= 3.18. So I
applied it to 3.12.

thanks,
-- 
js
suse labs