From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards To: Alim Akhtar , linux-samsung-soc@vger.kernel.org References: <1444653438-6532-1-git-send-email-alim.akhtar@samsung.com> From: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, k.kozlowski@samsung.com, kgene@kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, stable@vger.kernel.org Message-ID: <565C56BD.2050002@osg.samsung.com> Date: Mon, 30 Nov 2015 11:01:33 -0300 MIME-Version: 1.0 In-Reply-To: <1444653438-6532-1-git-send-email-alim.akhtar@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hello Alim, On 10/12/2015 09:37 AM, Alim Akhtar wrote: > Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"), > sound card detection is broken on peach boards and gives below errors: > > [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 > [ 3.634233] max98090 7-0010: use default 2.8v micbias > [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok > [ 3.645307] max98090 7-0010: Invalid master clock frequency > [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 > [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) > [ 3.664366] snow-audio: probe of sound failed with error -22 > > This patch adds missing assigned-clocks and assigned-clock-parents for > pmu_system_controller node which is used as "mclk" for audio codec. > > Signed-off-by: Alim Akhtar > Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards") I found that this patch is not enough to have proper audio working on an Exynos5800 Peach Pi. Even playing a simple wav does not work: $ time aplay -D sysdefault /usr/share/sounds/alsa/Front_Center.wav Playing WAVE '/usr/share/sounds/alsa/Front_Center.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Mono real 0m1.138s user 0m0.005s sys 0m0.005s This should be ~1.5 seconds so audio is processed faster than expected. So something else besides making the CLKOUT to provide a valid frequency for the codec's master clock is needed. Do you know what's missing in mainline? For instance, I see that the sound/soc/samsung/snow.c ASoC machine driver doesn't have a hw_params but I'm not that familiar with ALSA to know if that makes sense or not. Also, do you know if the "simple-audio-card" can be used instead for snow and peachs as it is used for other Exynos5 boards or a specific ASoC machine driver is really needed for these Chromebooks? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America