public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Burton <paulburton@google.com>,
	Joel Fernandes <joelaf@google.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] tracing: Simplify & fix saved_tgids logic
Date: Thu, 01 Jul 2021 14:07:17 -0700	[thread overview]
Message-ID: <5666edba28107559db23ba0f948c1f82@perches.com> (raw)
In-Reply-To: <20210701155100.3f29ddfb@oasis.local.home>

On 2021-07-01 12:51, Steven Rostedt wrote:
> On Thu, 01 Jul 2021 12:35:29 -0700
> Joe Perches <joe@perches.com> wrote:
> 
>> C99 comments are allowed since about 5 years ago.
> 
> Really, I thought Linus hated them. Personally, I find them rather ugly
> myself. The only user of them I see in the kernel/ directory appears to
> be for RCU. But Paul's on the C/C++ committee, so perhaps he favors 
> them.
> 
> The net/ directory doesn't have any, except perhaps to comment out code
> (which I sometimes use it for that too).
> 
> The block/, arch/x86/ directories don't have them either.
> 
> I wouldn't go and change checkpatch, but I still rather avoid them,
> especially for multi line comments.
> 
>  /*
>   * When it comes to multi line comments I prefer using something
>   * that denotes a start and an end to the comment, as it makes it
>   * look like a nice clip of information.
>   */
> 
> Instead of:
> 
>   // When it comes to multi line comments I prefer using something
>   // that denotes a start and an end to the comment, as it makes it
>   // look like a nice clip of information.
> 
> Which just looks like noise. But hey, maybe that's just me because I
> find "*" as a sign of information and '//' something to ignore. ;-)

May I suggest using something other than an amber vt220?




  reply	other threads:[~2021-07-01 21:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30  0:34 [PATCH 1/2] tracing: Simplify & fix saved_tgids logic Paul Burton
2021-06-30  0:34 ` [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX_DEFAULT Paul Burton
2021-06-30 12:35   ` Steven Rostedt
2021-06-30 21:09     ` Paul Burton
2021-06-30 21:34       ` Steven Rostedt
2021-06-30 22:34         ` Joel Fernandes
2021-06-30 23:11           ` Steven Rostedt
2021-07-01 13:55             ` Steven Rostedt
2021-07-01 17:24               ` [PATCH v2 1/2] tracing: Simplify & fix saved_tgids logic Paul Burton
2021-07-01 17:24                 ` [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not PID_MAX_DEFAULT Paul Burton
2021-07-01 18:12                   ` Steven Rostedt
2021-07-01 18:15                     ` Paul Burton
2021-07-01 18:27                       ` Steven Rostedt
2021-07-01 18:07                 ` [PATCH v2 1/2] tracing: Simplify & fix saved_tgids logic Joel Fernandes
2021-06-30 12:31 ` [PATCH " Steven Rostedt
2021-06-30 16:43   ` Joel Fernandes
2021-06-30 22:29 ` Joel Fernandes
2021-07-01 17:31   ` Paul Burton
2021-07-01 18:05     ` Joel Fernandes
2021-07-01 18:07     ` Steven Rostedt
2021-07-01 18:09       ` Joel Fernandes
2021-07-01 18:12       ` Paul Burton
2021-07-01 18:26         ` Steven Rostedt
2021-07-01 19:35           ` Joe Perches
2021-07-01 19:51             ` Steven Rostedt
2021-07-01 21:07               ` Joe Perches [this message]
2021-07-01 23:49                 ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5666edba28107559db23ba0f948c1f82@perches.com \
    --to=joe@perches.com \
    --cc=joelaf@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulburton@google.com \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox