From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:23700 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbbLJAto (ORCPT ); Wed, 9 Dec 2015 19:49:44 -0500 Subject: Re: [PATCH 3.19.y-ckt 084/164] thermal: exynos: Fix unbalanced regulator disable on probe failure To: Kamal Mostafa , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com References: <1449075615-20754-1-git-send-email-kamal@canonical.com> <1449075615-20754-85-git-send-email-kamal@canonical.com> <56682B8F.20006@samsung.com> Cc: k.kozlowski.k@gmail.com, Eduardo Valentin From: Krzysztof Kozlowski Message-id: <5668CC21.1070103@samsung.com> Date: Thu, 10 Dec 2015 09:49:37 +0900 MIME-version: 1.0 In-reply-to: <56682B8F.20006@samsung.com> Content-type: text/plain; charset=iso-8859-2 Content-transfer-encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 09.12.2015 22:24, Krzysztof Kozlowski wrote: > W dniu 03.12.2015 o 01:58, Kamal Mostafa pisze: >> 3.19.8-ckt11 -stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: Krzysztof Kozlowski >> >> commit 824ead03b78403a21449cb7eb153a4344cd3b4c8 upstream. >> >> During probe if the regulator could not be enabled, the error exit path >> would still disable it. This could lead to unbalanced counter of >> regulator enable/disable. >> >> The patch moves code for getting and enabling the regulator from >> exynos_map_dt_data() to probe function because it is really not a part >> of getting Device Tree properties. >> >> Acked-by: Lukasz Majewski >> Tested-by: Lukasz Majewski >> Reviewed-by: Alim Akhtar >> Signed-off-by: Krzysztof Kozlowski >> Fixes: 5f09a5cbd14a ("thermal: exynos: Disable the regulator on probe failure") >> Signed-off-by: Eduardo Valentin >> Signed-off-by: Kamal Mostafa >> --- >> drivers/thermal/samsung/exynos_tmu.c | 33 ++++++++++++++++----------------- >> 1 file changed, 16 insertions(+), 17 deletions(-) > > This patch shouldn't be backported before 4.2. It fixes a bug introduced > in 4.2: 5f09a5cbd14a. > > For kernels <4.2 this bug does not exist but fortunately the patch looks > harmless. Anyway I think that still it shouldn't be ported for <4.2. > > Best regards, > Krzysztof > Sorry for the noise, I was wrong. Luis pointed out that the 5f09a5cbd14a was itself backported to 3.19 so this applies to backporting as well. No objections from my side. Best regards, Krzysztof