From: Sasha Levin <sasha.levin@oracle.com>
To: Paul Mackerras <paulus@ozlabs.org>, linux-kernel@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
stable@vger.kernel.org
Subject: Re: Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23
Date: Mon, 14 Dec 2015 12:15:47 -0500 [thread overview]
Message-ID: <566EF943.9070501@oracle.com> (raw)
In-Reply-To: <20151214024426.GA23275@iris.ozlabs.ibm.com>
On 12/13/2015 09:44 PM, Paul Mackerras wrote:
> Commit d9a1133495b4 ("net: Fix skb_set_peeked use-after-free bug") in
> 3.18.23 claims to be a backport of commit a0a2a6602496, but in fact
> the patch is identical to commit 738ac1ebb96d ("net: Clone skb before
> setting peeked flag"), which is the commit that introduces the
> use-after-free bug that a0a2a6602496 fixes.
>
> The result is that we have been seeing crashes in __skb_recv_datagram
> since I merged v3.18.24 into the kernel code we are using for a
> product. Could someone fix this with an actual backport of
> a0a2a6602496 please?
Sorry about that, looks like my script has gone haywire :/
I've fixed it, pushed queue and will ship tomorrow after testing.
Thanks,
Sasha
prev parent reply other threads:[~2015-12-14 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 2:44 Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23 Paul Mackerras
2015-12-14 17:15 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566EF943.9070501@oracle.com \
--to=sasha.levin@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@ozlabs.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).