* Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23
@ 2015-12-14 2:44 Paul Mackerras
2015-12-14 17:15 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Paul Mackerras @ 2015-12-14 2:44 UTC (permalink / raw)
To: Sasha Levin, linux-kernel; +Cc: Herbert Xu, David S. Miller, stable
Commit d9a1133495b4 ("net: Fix skb_set_peeked use-after-free bug") in
3.18.23 claims to be a backport of commit a0a2a6602496, but in fact
the patch is identical to commit 738ac1ebb96d ("net: Clone skb before
setting peeked flag"), which is the commit that introduces the
use-after-free bug that a0a2a6602496 fixes.
The result is that we have been seeing crashes in __skb_recv_datagram
since I merged v3.18.24 into the kernel code we are using for a
product. Could someone fix this with an actual backport of
a0a2a6602496 please?
Thanks,
Paul.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23
2015-12-14 2:44 Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23 Paul Mackerras
@ 2015-12-14 17:15 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2015-12-14 17:15 UTC (permalink / raw)
To: Paul Mackerras, linux-kernel; +Cc: Herbert Xu, David S. Miller, stable
On 12/13/2015 09:44 PM, Paul Mackerras wrote:
> Commit d9a1133495b4 ("net: Fix skb_set_peeked use-after-free bug") in
> 3.18.23 claims to be a backport of commit a0a2a6602496, but in fact
> the patch is identical to commit 738ac1ebb96d ("net: Clone skb before
> setting peeked flag"), which is the commit that introduces the
> use-after-free bug that a0a2a6602496 fixes.
>
> The result is that we have been seeing crashes in __skb_recv_datagram
> since I merged v3.18.24 into the kernel code we are using for a
> product. Could someone fix this with an actual backport of
> a0a2a6602496 please?
Sorry about that, looks like my script has gone haywire :/
I've fixed it, pushed queue and will ship tomorrow after testing.
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-14 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 2:44 Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23 Paul Mackerras
2015-12-14 17:15 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).