From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pf0-f170.google.com ([209.85.192.170]:32836 "EHLO
	mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933565AbbLOPPN (ORCPT
	<rfc822;stable@vger.kernel.org>); Tue, 15 Dec 2015 10:15:13 -0500
Received: by mail-pf0-f170.google.com with SMTP id n128so6283135pfn.0
        for <stable@vger.kernel.org>; Tue, 15 Dec 2015 07:15:12 -0800 (PST)
Subject: Re: [PATCH 4.3] vrf: Fix memory leak on registration failure in
 vrf_newlink()
To: Ben Hutchings <ben@decadent.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20151215151243.GN28542@decadent.org.uk>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	"David S. Miller" <davem@davemloft.net>
From: David Ahern <dsa@cumulusnetworks.com>
Message-ID: <56702E7E.5000604@cumulusnetworks.com>
Date: Tue, 15 Dec 2015 08:15:10 -0700
MIME-Version: 1.0
In-Reply-To: <20151215151243.GN28542@decadent.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 12/15/15 8:12 AM, Ben Hutchings wrote:
> @@ -598,7 +599,10 @@ static int vrf_newlink(struct net *src_net, struct net_device *dev,
>
>   	rcu_assign_pointer(dev->vrf_ptr, vrf_ptr);
>
> -	return register_netdev(dev);
> +	err = register_netdev(dev);
> +	if (err)
> +		kfree(vrf_ptr);
> +	return err;
>   }
>
>   static size_t vrf_nl_getsize(const struct net_device *dev)
>

The rcu_assign_pointer should only be done if the register_netdev succeeded.

Thanks for creating the patch.