From: Richard Weinberger <richard@nod.at>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-mtd <linux-mtd@lists.infradead.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()
Date: Fri, 15 May 2020 22:50:14 +0200 (CEST) [thread overview]
Message-ID: <568077266.223149.1589575814867.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20200515191704.GE1009@sol.localdomain>
----- Ursprüngliche Mail -----
> Von: "Eric Biggers" <ebiggers@kernel.org>
> An: "Sascha Hauer" <s.hauer@pengutronix.de>, "richard" <richard@nod.at>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>, "stable"
> <stable@vger.kernel.org>
> Gesendet: Freitag, 15. Mai 2020 21:17:04
> Betreff: Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()
> On Mon, May 04, 2020 at 09:16:44AM +0200, Sascha Hauer wrote:
>> On Fri, May 01, 2020 at 10:59:45PM -0700, Eric Biggers wrote:
>> > From: Eric Biggers <ebiggers@google.com>
>> >
>> > crypto_shash_descsize() returns the size of the shash_desc context
>> > needed to compute the hash, not the size of the hash itself.
>> >
>> > crypto_shash_digestsize() would be correct, or alternatively using
>> > c->hash_len and c->hmac_desc_len which already store the correct values.
>> > But actually it's simpler to just use stack arrays, so do that instead.
>> >
>> > Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication support")
>> > Fixes: da8ef65f9573 ("ubifs: Authenticate replayed journal")
>> > Cc: <stable@vger.kernel.org> # v4.20+
>> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>>
>> Looks better that way, thanks.
>>
>> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>>
>
> Richard, could you take this through the ubifs tree for 5.8?
Sure. I actually will send a PR with various MTD related fixes
for 5.7.
Thanks,
//richard
next prev parent reply other threads:[~2020-05-15 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 5:59 [PATCH] ubifs: fix wrong use of crypto_shash_descsize() Eric Biggers
2020-05-04 7:16 ` Sascha Hauer
2020-05-15 19:17 ` Eric Biggers
2020-05-15 20:50 ` Richard Weinberger [this message]
2020-05-17 21:39 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568077266.223149.1589575814867.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).