From: Lu Baolu <baolu.lu@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oliver Neukum <oliver@neukum.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Tang Jian Qiang <jianqiang.tang@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read callback
Date: Wed, 30 Dec 2015 13:01:30 +0800 [thread overview]
Message-ID: <5683652A.80001@linux.intel.com> (raw)
In-Reply-To: <20151230014651.GA19447@kroah.com>
On 12/30/2015 09:46 AM, Greg Kroah-Hartman wrote:
> On Wed, Dec 30, 2015 at 08:42:01AM +0800, Lu Baolu wrote:
>> In current acm driver, the bulk-in callback function ignores the
>> URBs unlinked in usb core.
>>
>> This causes unexpected data loss in some cases. For example,
>> runtime suspend entry will unlinked all urbs and set urb->status
>> to -ENOENT even those urbs might have data not processed yet.
>> Hence, data loss occurs.
>>
>> This patch lets bulk-in callback function handle unlinked urbs
>> to avoid data loss.
>>
>> Signed-off-by: Tang Jian Qiang <jianqiang.tang@intel.com>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Cc: stable@vger.kernel.org
>> Acked-by: Oliver Neukum <oneukum@suse.com>
>> ---
>> drivers/usb/class/cdc-acm.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
> What changed in v2?
>
> Please always document that below the --- line.
Thank you for the reminding.
I will send a new version of patch with change logs.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-12-30 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 0:42 [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read callback Lu Baolu
2015-12-30 1:46 ` Greg Kroah-Hartman
2015-12-30 5:01 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5683652A.80001@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jianqiang.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).