From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:7403 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbbL3FBc (ORCPT ); Wed, 30 Dec 2015 00:01:32 -0500 Subject: Re: [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read callback To: Greg Kroah-Hartman References: <1451436121-3089-1-git-send-email-baolu.lu@linux.intel.com> <20151230014651.GA19447@kroah.com> Cc: Oliver Neukum , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Jian Qiang , stable@vger.kernel.org From: Lu Baolu Message-ID: <5683652A.80001@linux.intel.com> Date: Wed, 30 Dec 2015 13:01:30 +0800 MIME-Version: 1.0 In-Reply-To: <20151230014651.GA19447@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 12/30/2015 09:46 AM, Greg Kroah-Hartman wrote: > On Wed, Dec 30, 2015 at 08:42:01AM +0800, Lu Baolu wrote: >> In current acm driver, the bulk-in callback function ignores the >> URBs unlinked in usb core. >> >> This causes unexpected data loss in some cases. For example, >> runtime suspend entry will unlinked all urbs and set urb->status >> to -ENOENT even those urbs might have data not processed yet. >> Hence, data loss occurs. >> >> This patch lets bulk-in callback function handle unlinked urbs >> to avoid data loss. >> >> Signed-off-by: Tang Jian Qiang >> Signed-off-by: Lu Baolu >> Cc: stable@vger.kernel.org >> Acked-by: Oliver Neukum >> --- >> drivers/usb/class/cdc-acm.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > What changed in v2? > > Please always document that below the --- line. Thank you for the reminding. I will send a new version of patch with change logs. > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >