From: Jiri Slaby <jslaby@suse.cz>
To: linux-kernel@vger.kernel.org, hch@lst.de, keith.busch@intel.com,
axboe@fb.com, stable@vger.kernel.org
Cc: Michal Marek <MMarek@suse.com>, Kernel Build Daemon <kbuild@suse.de>
Subject: Re: [PATCH] uapi: update install list after nvme.h rename
Date: Thu, 14 Jan 2016 09:26:15 +0100 [thread overview]
Message-ID: <56975BA7.10905@suse.cz> (raw)
In-Reply-To: <20160114011720.GT4894@vapier.lan>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
> On 12 Jan 2016 09:45, Jiri Slaby wrote:
>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of the
>>> uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, but
>>> the uapi list still refers to nvme.h. People trying to install
>>> the headers hit a failure as the header no longer exists.
>>
>> Wouldn't reverting the rename be nicer to userspace? So that the
>> filename is preserved and anybody who #included nvme.h still can
>> do so?
>
> i have no opinion on either route
>
> on a related note, shouldn't headers install be part of the
> automatic kernel checks that are run against repos on kernel.org ?
> who runs that thing ?
I have been thinking about at least 'test -f' for all 'headers-y'
during make all. What do you think, Michal?
thanks,
- --
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJWl1ukAAoJEL0lsQQGtHBJq6oP/jNH+N/Hf8JtZN0xOmv2qhnS
x7n/jlDvE8ineXVFlAQghu5+RDq4tSJ6lllKjGLh5Y3IyHF24zbsAwl2ojnORxH9
ALrcs4KorQXNU3WrzY5+5Ah6oUtHp2mKBpDOPYHiCA0yhZxHDWZm4ecF3lhRb6sn
jFkVpgvmD0sd5XUjsbIa/B0ugD8dMjGOdc7kZVpdEN1zmGYKoMD6gs/LTVvh3gUJ
ohWsSTEBYlUeq/TnFcU+WbnH3Fxbgapktbqo9HX1O4iKiXQDBYcOBcGnm5mJAcPz
RhEMDAL7/x/R/pzcnwMPAjPseLUdLs8jTSeOF+BNyzsHTallneN3C9UXa+LSj4Wf
F0yd485xyz+gHDd2G9CG6jEQ8SurWk8Bb4BxLNKALBmmEIy6FbgIsxUjeY0JMMDj
C8iRCI+vyaijTmBiNRxTWHsbN7AtH4X3f3/DjmWEVCro6QjRj9g5SPykCckN+c8F
NvVVnbjXBQLTh69RIyDTQ1E6hKA+E3605OVCrY1YMpcx8/714IxuWhA9BCxVzF7p
RnKa6AAVzylf7WMlX5qrQ1GoHmCzi8GPY6tlFpoQ/FFgN2Y/uS3zIRlqkSXBd0lb
yMFjkfBPpNu4Xe3L6AYD7sAUl3U1VKnvKqqyTuTZx8qbFb2xdTDKYYiRZEw4yc+b
9ODjcHuxDLcJSjnlTU8N
=tIm3
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-01-14 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 1:14 [PATCH] uapi: update install list after nvme.h rename Mike Frysinger
2016-01-12 8:45 ` Jiri Slaby
2016-01-14 1:17 ` Mike Frysinger
2016-01-14 8:26 ` Jiri Slaby [this message]
2016-01-14 8:30 ` Jiri Slaby
2016-02-19 22:23 ` Mario Limonciello
2016-02-19 22:37 ` Jens Axboe
2016-01-12 15:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56975BA7.10905@suse.cz \
--to=jslaby@suse.cz \
--cc=MMarek@suse.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbuild@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).