From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq To: Wenbo Wang , keith.busch@intel.com, axboe@fb.com References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> Cc: stable@vger.kernel.org, wenwei.tao@memblaze.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Wenbo Wang From: Sagi Grimberg Message-ID: <569F7EE3.1020504@dev.mellanox.co.il> Date: Wed, 20 Jan 2016 14:34:43 +0200 MIME-Version: 1.0 In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt triggered nvme_process_cq may access nvmeq->q_db just > before it is updated, this could cause kernel panic. > > Signed-off-by: Wenbo Wang > Reviewed-by: Wenwei Tao You should add Cc: stable@vger.kernel.org here, git-send-email will take care of the CC for you.