* [PATCH] acpi: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist"
@ 2016-01-22 10:41 Hans de Goede
2016-01-22 13:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2016-01-22 10:41 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: erusan, Zhang Rui, Len Brown, linux-acpi, Hans de Goede, stable
The quirk to get "acpi_backlight=vendor" behavior by default on the
Dell Inspiron 5737 was added before we started doing
"acpi_backlight=native" by default on Win8 ready machines.
Since we now avoid using acpi-video as backlight driver on these machines
by default (using the native driver instead) we no longer need this quirk.
Moreover the vendor driver does not work after a suspend/resume where
as the native driver does.
This reverts commit 08a56226d847 ("ACPI / video: Add Dell Inspiron 5737
to the blacklist").
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=111061
Cc: stable@vger.kernel.org
Reported-and-tested-by: erusan@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/video_detect.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 90e2d54..1316ddd 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -135,14 +135,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
},
},
- {
- .callback = video_detect_force_vendor,
- .ident = "Dell Inspiron 5737",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
- },
- },
/*
* These models have a working acpi_video backlight control, and using
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] acpi: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist"
2016-01-22 10:41 [PATCH] acpi: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist" Hans de Goede
@ 2016-01-22 13:44 ` Rafael J. Wysocki
2016-01-22 13:51 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-01-22 13:44 UTC (permalink / raw)
To: Hans de Goede; +Cc: erusan, Zhang Rui, Len Brown, linux-acpi, stable
On Friday, January 22, 2016 11:41:05 AM Hans de Goede wrote:
> The quirk to get "acpi_backlight=vendor" behavior by default on the
> Dell Inspiron 5737 was added before we started doing
> "acpi_backlight=native" by default on Win8 ready machines.
>
> Since we now avoid using acpi-video as backlight driver on these machines
> by default (using the native driver instead) we no longer need this quirk.
>
> Moreover the vendor driver does not work after a suspend/resume where
> as the native driver does.
>
> This reverts commit 08a56226d847 ("ACPI / video: Add Dell Inspiron 5737
> to the blacklist").
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=111061
> Cc: stable@vger.kernel.org
OK, but I think we need to limit the range of "stable" kernels this is
going to go into.
What's the least recent "stable" series one you'd like this to be applied to?
> Reported-and-tested-by: erusan@gmail.com
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/acpi/video_detect.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 90e2d54..1316ddd 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -135,14 +135,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
> },
> },
> - {
> - .callback = video_detect_force_vendor,
> - .ident = "Dell Inspiron 5737",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
> - },
> - },
>
> /*
> * These models have a working acpi_video backlight control, and using
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] acpi: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist"
2016-01-22 13:44 ` Rafael J. Wysocki
@ 2016-01-22 13:51 ` Hans de Goede
2016-01-23 2:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2016-01-22 13:51 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: erusan, Zhang Rui, Len Brown, linux-acpi, stable
Hi,
On 22-01-16 14:44, Rafael J. Wysocki wrote:
> On Friday, January 22, 2016 11:41:05 AM Hans de Goede wrote:
>> The quirk to get "acpi_backlight=vendor" behavior by default on the
>> Dell Inspiron 5737 was added before we started doing
>> "acpi_backlight=native" by default on Win8 ready machines.
>>
>> Since we now avoid using acpi-video as backlight driver on these machines
>> by default (using the native driver instead) we no longer need this quirk.
>>
>> Moreover the vendor driver does not work after a suspend/resume where
>> as the native driver does.
>>
>> This reverts commit 08a56226d847 ("ACPI / video: Add Dell Inspiron 5737
>> to the blacklist").
>>
>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=111061
>> Cc: stable@vger.kernel.org
>
> OK, but I think we need to limit the range of "stable" kernels this is
> going to go into.
>
> What's the least recent "stable" series one you'd like this to be applied to?
3.19 and later have this commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/acpi/video.c?id=fbc9fe1b4f222a7c575e3bd8e9defe59c6190a04
And thus will use native backlight by default, so anything >= 3.19.
Regards,
Hans
>
>> Reported-and-tested-by: erusan@gmail.com
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/acpi/video_detect.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>> index 90e2d54..1316ddd 100644
>> --- a/drivers/acpi/video_detect.c
>> +++ b/drivers/acpi/video_detect.c
>> @@ -135,14 +135,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>> DMI_MATCH(DMI_PRODUCT_NAME, "UL30A"),
>> },
>> },
>> - {
>> - .callback = video_detect_force_vendor,
>> - .ident = "Dell Inspiron 5737",
>> - .matches = {
>> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> - DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5737"),
>> - },
>> - },
>>
>> /*
>> * These models have a working acpi_video backlight control, and using
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] acpi: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist"
2016-01-22 13:51 ` Hans de Goede
@ 2016-01-23 2:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-01-23 2:09 UTC (permalink / raw)
To: Hans de Goede; +Cc: erusan, Zhang Rui, Len Brown, linux-acpi, stable
On Friday, January 22, 2016 02:51:39 PM Hans de Goede wrote:
> Hi,
>
> On 22-01-16 14:44, Rafael J. Wysocki wrote:
> > On Friday, January 22, 2016 11:41:05 AM Hans de Goede wrote:
> >> The quirk to get "acpi_backlight=vendor" behavior by default on the
> >> Dell Inspiron 5737 was added before we started doing
> >> "acpi_backlight=native" by default on Win8 ready machines.
> >>
> >> Since we now avoid using acpi-video as backlight driver on these machines
> >> by default (using the native driver instead) we no longer need this quirk.
> >>
> >> Moreover the vendor driver does not work after a suspend/resume where
> >> as the native driver does.
> >>
> >> This reverts commit 08a56226d847 ("ACPI / video: Add Dell Inspiron 5737
> >> to the blacklist").
> >>
> >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=111061
> >> Cc: stable@vger.kernel.org
> >
> > OK, but I think we need to limit the range of "stable" kernels this is
> > going to go into.
> >
> > What's the least recent "stable" series one you'd like this to be applied to?
>
> 3.19 and later have this commit:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/acpi/video.c?id=fbc9fe1b4f222a7c575e3bd8e9defe59c6190a04
>
> And thus will use native backlight by default, so anything >= 3.19.
OK, applied.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-23 2:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-22 10:41 [PATCH] acpi: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist" Hans de Goede
2016-01-22 13:44 ` Rafael J. Wysocki
2016-01-22 13:51 ` Hans de Goede
2016-01-23 2:09 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).