From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy
 interrupt
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
References: <1452846618-17854-1-git-send-email-alexandre.belloni@free-electrons.com>
CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Message-ID: <56A254D6.3070105@atmel.com>
Date: Fri, 22 Jan 2016 17:12:06 +0100
MIME-Version: 1.0
In-Reply-To: <1452846618-17854-1-git-send-email-alexandre.belloni@free-electrons.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Le 15/01/2016 09:30, Alexandre Belloni a �crit :
> No interrupt were received from the phy because PIOE 1 may not be properly
> muxed. It prevented proper link detection, especially since commit
> 321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
> disables polling.
> 
> Cc: <stable@vger.kernel.org> # 4.4
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

And added to the upcoming at91-4.5-fixes branch.

thanks!


> ---
>  arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 131614f28e75..8cf9999cb0cd 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -86,6 +86,8 @@
>  			macb0: ethernet@f8020000 {
>  				phy-mode = "rmii";
>  				status = "okay";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
>  
>  				phy0: ethernet-phy@1 {
>  					interrupt-parent = <&pioE>;
> @@ -152,6 +154,10 @@
>  						atmel,pins =
>  							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
>  					};
> +					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
> +						atmel,pins =
> +							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> +					};
>  				};
>  			};
>  		};
> 


-- 
Nicolas Ferre