From: Avi Kivity <avi@scylladb.com>
To: Greg KH <greg@kroah.com>
Cc: Jan Kara <jack@suse.cz>,
axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
Jeff Moyer <jmoyer@redhat.com>,
stable@vger.kernel.org, Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH] direct-io: Fix negative return from dio read beyond eof
Date: Wed, 27 Jan 2016 19:16:32 +0200 [thread overview]
Message-ID: <56A8FB70.6040803@scylladb.com> (raw)
In-Reply-To: <20160127171302.GA2943@kroah.com>
On 01/27/2016 07:13 PM, Greg KH wrote:
> On Wed, Jan 27, 2016 at 12:38:14PM +0200, Avi Kivity wrote:
>> On 11/19/2015 10:25 PM, Jan Kara wrote:
>>> Assume a filesystem with 4KB blocks. When a file has size 1000 bytes and
>>> we issue direct IO read at offset 1024, blockdev_direct_IO() reads the
>>> tail of the last block and the logic for handling short DIO reads in
>>> dio_complete() results in a return value -24 (1000 - 1024) which
>>> obviously confuses userspace.
>>>
>>> Fix the problem by bailing out early once we sample i_size and can
>>> reliably check that direct IO read starts beyond i_size.
>>>
>>> Reported-by: Avi Kivity <avi@scylladb.com>
>>> Fixes: 9fe55eea7e4b444bafc42fa0000cc2d1d2847275
>>> CC: stable@vger.kernel.org
>> While this patch made it into upstream, it did not appear in 4.3.4. Did it
>> slip through the proverbial cracks? Can it be queued for 4.3.5?
> There are over 400 patches right now in my queue that haven't made it
> into a 4.3.x kernel.
Many projects would consider 400 patches a major release, and here they
are behind two dots...
> These are in the queue, in good company :)
>
> I'll go dig these out as I guess people care about them more than
> others...
>
>
Much appreciated.
next prev parent reply other threads:[~2016-01-27 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 20:25 [PATCH] direct-io: Fix negative return from dio read beyond eof Jan Kara
2015-11-30 13:10 ` Jan Kara
2015-11-30 17:16 ` Jens Axboe
2016-01-27 10:38 ` Avi Kivity
2016-01-27 17:13 ` Greg KH
2016-01-27 17:16 ` Avi Kivity [this message]
2016-01-27 17:45 ` Greg KH
2016-01-27 17:46 ` Greg KH
2016-01-27 17:49 ` Avi Kivity
2016-01-27 17:52 ` Avi Kivity
2016-01-27 17:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8FB70.6040803@scylladb.com \
--to=avi@scylladb.com \
--cc=axboe@kernel.dk \
--cc=greg@kroah.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).