From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:24541 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932073AbcBEPzi (ORCPT ); Fri, 5 Feb 2016 10:55:38 -0500 Subject: Re: [PATCH 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, konrad.wilk@oracle.com, david.vrabel@citrix.com References: <1454678123-7632-1-git-send-email-jgross@suse.com> <1454678503-7999-1-git-send-email-jgross@suse.com> <1454678503-7999-2-git-send-email-jgross@suse.com> <56B4C4D7.90202@oracle.com> Cc: stable@vger.kernel.org From: Boris Ostrovsky Message-ID: <56B4C5F0.8080501@oracle.com> Date: Fri, 5 Feb 2016 10:55:28 -0500 MIME-Version: 1.0 In-Reply-To: <56B4C4D7.90202@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 02/05/2016 10:50 AM, Boris Ostrovsky wrote: > > >> @@ -962,33 +973,31 @@ static int >> scsiback_del_translation_entry(struct vscsibk_info *info, >> struct ids_tuple *v) >> { >> struct v2p_entry *entry; >> - struct list_head *head = &(info->v2p_entry_lists); >> unsigned long flags; >> spin_lock_irqsave(&info->v2p_lock, flags); >> /* Find out the translation entry specified */ >> - list_for_each_entry(entry, head, l) { >> - if ((entry->v.chn == v->chn) && >> - (entry->v.tgt == v->tgt) && >> - (entry->v.lun == v->lun)) { >> - goto found; >> - } >> - } >> - >> - spin_unlock_irqrestore(&info->v2p_lock, flags); >> - return 1; >> - >> -found: >> - /* Delete the translation entry specfied */ >> - __scsiback_del_translation_entry(entry); >> + entry = scsiback_chk_translation_entry(info, v); >> + if (entry) >> + __scsiback_del_translation_entry(entry); >> spin_unlock_irqrestore(&info->v2p_lock, flags); >> - return 0; >> + return entry == NULL; > > Might be better to return -ENOENT instead of 1 above and -EEXISTS if > entry!=NULL, given that this returns an int. Nevermind reference to 1, it's removed. But returning an error code instead of a bool is still better I think. -boris