From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base To: Rob Herring References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56BC6ABA.5020605@arm.com> Cc: Robin Murphy , Frank Rowand , Grant Likely , "devicetree@vger.kernel.org" , Mark Rutland , David Daney , stuart.yoder@nxp.com, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , stable From: Marc Zyngier Message-ID: <56BD988C.6090909@arm.com> Date: Fri, 12 Feb 2016 08:32:12 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 11/02/16 23:15, Rob Herring wrote: > On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier wrote: >> On 09/02/16 11:04, Robin Murphy wrote: >>> The existing msi-map code is fine for shifting the entire RID space >>> upwards, but attempting finer-grained remapping reveals a bug. It turns >>> out that we are mistakenly treating the msi-base part as an offset, not >>> as a new base to remap onto, so things get squiffy when rid-base is >>> nonzero. Fix this, and at the same time add a sanity check against >>> having msi-map-mask clash with a nonzero rid-base, as that's another >>> thing one can easily get wrong. >>> >>> CC: >>> Signed-off-by: Robin Murphy >> >> Rob, Frank, >> >> Are you willing to take this one through the OF tree? Or should we route >> it through the IRQ tree? It'd be good if it make it into 4.5. > > Applied for 4.5. ATM, I don't have anything else to send to Linus. > I'll give it a week or so if this is not urgent. Or send me a bunch of > DT binding fixes and you can get it in sooner. ;) Doesn't really qualify as "a bunch", but how about this one: https://patchwork.ozlabs.org/patch/578268/ I had it in mind for 4.6, but the sooner the better! Thanks, M. -- Jazz is not dead. It just smells funny...