Re: Build errors in v3.18-stable-queue

[Sasha Levin <sasha.levin@oracle.com>]

On 03/01/2016 06:12 AM, Youngmin Nam wrote:
> On 2016년 02월 28일 19:45, Guenter Roeck wrote:
>> Current build results:
>>     total: 137 pass: 121 fail: 16
>> Failed builds:
>>     arm:allmodconfig
>>     arm:omap2plus_defconfig
>>     arm:exynos_defconfig
>>     arm:s5pv210_defconfig
>>     powerpc:defconfig
>>     powerpc:allmodconfig
>>     powerpc:allnoconfig
>>     powerpc:ppc64e_defconfig
>>     powerpc:cell_defconfig
>>     powerpc:maple_defconfig
>>     powerpc:ppc6xx_defconfig
>>     powerpc:mpc83xx_defconfig
>>     powerpc:tqm8xx_defconfig
>>     powerpc:85xx/sbc8548_defconfig
>>     powerpc:83xx/mpc834x_mds_defconfig
>>     powerpc:86xx/sbc8641d_defconfig
>>
>> Culprits are listed below. Copying the patch authors for advice.
>>
>> Guenter
>>
>> ---
>> powerpc:
>>
>> In file included from arch/powerpc/kernel/of_platform.c:30:0:
>> ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list
>>
>> Culprit: "powerpc/eeh: Do probe on pci_dn"
>>
>> ---
>> arm:
>>
>> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set':
>> drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data'
>>
>> Culprit: "pinctrl: samsung: fix SMP race condition"
>>
>> drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx':
>> drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485'
>>
>> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
>> drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config'
>>
>> Culprit: "serial/omap: Use the rs485 functions on serial_core"
> 
> Thanks Guenter. I think below Linus' patch will also need to fix the build error.
> 
> commit b08ea35a3296ee25c4cb53a977b752266dafa2c2
> Author: Linus Walleij <linus.walleij@linaro.org>
> Date: Thu Dec 3 15:14:13 2015 +0100
> 
> gpio: add a data pointer to gpio_chip
> 
> This adds a void * pointer to gpio_chip so that driver can
> assign and retrieve some states. This is done to get rid of
> container_of() calls for gpio_chips embedded inside state
> containers, so we can remove the need to have the gpio_chip
> or later (planned) struct gpio_device be dynamically allocated
> at registration time, so that its struct device can be properly
> reference counted and not bound to its parent device (e.g.
> a platform_device) but instead live on after unregistration
> if it is opened by e.g. a char device or sysfs.
> 
> The data is added with the new function gpiochip_add_data()
> and for compatibility we add static inline wrapper function
> gpiochip_add() that will call gpiochip_add_data() with
> NULL as argument. The latter will be removed once we have
> exorcised gpiochip_add() from the kernel.
> 
> gpiochip_get_data() is added as a static inline accessor
> for drivers to quickly get their data out.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 

Hi Youngmin,

This won't be enough as that commit merely adds a field but doesn't add any
usages of that field, so adding that patch into -stable would "fix" the build
error but would break the device itself.


Thanks,
Sasha