* Build errors in v3.18-stable-queue @ 2016-02-28 10:45 Guenter Roeck 2016-03-01 0:24 ` Sasha Levin 2016-03-01 11:12 ` Youngmin Nam 0 siblings, 2 replies; 12+ messages in thread From: Guenter Roeck @ 2016-02-28 10:45 UTC (permalink / raw) To: stable; +Cc: Sasha Levin, Youngmin Nam, Gavin Shan, Alan Cox Current build results: total: 137 pass: 121 fail: 16 Failed builds: arm:allmodconfig arm:omap2plus_defconfig arm:exynos_defconfig arm:s5pv210_defconfig powerpc:defconfig powerpc:allmodconfig powerpc:allnoconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig powerpc:maple_defconfig powerpc:ppc6xx_defconfig powerpc:mpc83xx_defconfig powerpc:tqm8xx_defconfig powerpc:85xx/sbc8548_defconfig powerpc:83xx/mpc834x_mds_defconfig powerpc:86xx/sbc8641d_defconfig Culprits are listed below. Copying the patch authors for advice. Guenter --- powerpc: In file included from arch/powerpc/kernel/of_platform.c:30:0: ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list Culprit: "powerpc/eeh: Do probe on pci_dn" --- arm: drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' Culprit: "pinctrl: samsung: fix SMP race condition" drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' Culprit: "serial/omap: Use the rs485 functions on serial_core" ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-02-28 10:45 Build errors in v3.18-stable-queue Guenter Roeck @ 2016-03-01 0:24 ` Sasha Levin 2016-03-01 1:14 ` Gavin Shan 2016-03-02 4:31 ` Guenter Roeck 2016-03-01 11:12 ` Youngmin Nam 1 sibling, 2 replies; 12+ messages in thread From: Sasha Levin @ 2016-03-01 0:24 UTC (permalink / raw) To: Guenter Roeck, stable; +Cc: Youngmin Nam, Gavin Shan, Alan Cox On 02/28/2016 05:45 AM, Guenter Roeck wrote: > Current build results: > total: 137 pass: 121 fail: 16 > Failed builds: > arm:allmodconfig > arm:omap2plus_defconfig > arm:exynos_defconfig > arm:s5pv210_defconfig > powerpc:defconfig > powerpc:allmodconfig > powerpc:allnoconfig > powerpc:ppc64e_defconfig > powerpc:cell_defconfig > powerpc:maple_defconfig > powerpc:ppc6xx_defconfig > powerpc:mpc83xx_defconfig > powerpc:tqm8xx_defconfig > powerpc:85xx/sbc8548_defconfig > powerpc:83xx/mpc834x_mds_defconfig > powerpc:86xx/sbc8641d_defconfig > > Culprits are listed below. Copying the patch authors for advice. > > Guenter > > --- > powerpc: > > In file included from arch/powerpc/kernel/of_platform.c:30:0: > ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list > > Culprit: "powerpc/eeh: Do probe on pci_dn" > > --- > arm: > > drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': > drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' > > Culprit: "pinctrl: samsung: fix SMP race condition" > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': > drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': > drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' > > Culprit: "serial/omap: Use the rs485 functions on serial_core" Thanks Guenter. I'll pull both of these out of 3.18 and 4.1 until we can get a proper backport since it doesn't seem trivial. Thanks, Sasha ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 0:24 ` Sasha Levin @ 2016-03-01 1:14 ` Gavin Shan 2016-03-01 2:47 ` Guenter Roeck 2016-03-02 4:31 ` Guenter Roeck 1 sibling, 1 reply; 12+ messages in thread From: Gavin Shan @ 2016-03-01 1:14 UTC (permalink / raw) To: Sasha Levin; +Cc: Guenter Roeck, stable, Youngmin Nam, Gavin Shan, Alan Cox On Mon, Feb 29, 2016 at 07:24:33PM -0500, Sasha Levin wrote: >On 02/28/2016 05:45 AM, Guenter Roeck wrote: >> Current build results: >> total: 137 pass: 121 fail: 16 >> Failed builds: >> arm:allmodconfig >> arm:omap2plus_defconfig >> arm:exynos_defconfig >> arm:s5pv210_defconfig >> powerpc:defconfig >> powerpc:allmodconfig >> powerpc:allnoconfig >> powerpc:ppc64e_defconfig >> powerpc:cell_defconfig >> powerpc:maple_defconfig >> powerpc:ppc6xx_defconfig >> powerpc:mpc83xx_defconfig >> powerpc:tqm8xx_defconfig >> powerpc:85xx/sbc8548_defconfig >> powerpc:83xx/mpc834x_mds_defconfig >> powerpc:86xx/sbc8641d_defconfig >> >> Culprits are listed below. Copying the patch authors for advice. >> Thanks for reporting it, Guenter. some questions as below: - The subject says you were building 3.18 stable kernel, but the PowerPC related commit was merged to 4.1 kernel. So I assume you were building 4.1 stable kernel instead. - All above PowerPC configuration failed to build? At least, those configuration that has (CONFIG_PPC64=y) shouldn't fail because of the error you pointed. - Those configuration without (CONFIG_PPC64=y) needs below fix. Could you please have a try? If it works, I'll post a patch as soon as possible. diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c index b60a67d..25dec0b 100644 --- a/arch/powerpc/kernel/of_platform.c +++ b/arch/powerpc/kernel/of_platform.c @@ -71,8 +71,10 @@ static int of_pci_phb_probe(struct platform_device *dev) eeh_dev_phb_init_dynamic(phb); /* Register devices with EEH */ +#ifdef CONFIG_EEH if (dev->dev.of_node->child) eeh_add_device_tree_early(PCI_DN(dev->dev.of_node)); +#endif Thanks, Gavin >> Guenter >> >> --- >> powerpc: >> >> In file included from arch/powerpc/kernel/of_platform.c:30:0: >> ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list >> >> Culprit: "powerpc/eeh: Do probe on pci_dn" >> >> --- >> arm: >> >> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': >> drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' >> >> Culprit: "pinctrl: samsung: fix SMP race condition" >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': >> drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': >> drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' >> >> Culprit: "serial/omap: Use the rs485 functions on serial_core" > > >Thanks Guenter. I'll pull both of these out of 3.18 and 4.1 until we can get a proper >backport since it doesn't seem trivial. > > >Thanks, >Sasha > ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 1:14 ` Gavin Shan @ 2016-03-01 2:47 ` Guenter Roeck 2016-03-01 5:06 ` Gavin Shan 0 siblings, 1 reply; 12+ messages in thread From: Guenter Roeck @ 2016-03-01 2:47 UTC (permalink / raw) To: Gavin Shan, Sasha Levin; +Cc: stable, Youngmin Nam, Alan Cox On 02/29/2016 05:14 PM, Gavin Shan wrote: > On Mon, Feb 29, 2016 at 07:24:33PM -0500, Sasha Levin wrote: >> On 02/28/2016 05:45 AM, Guenter Roeck wrote: >>> Current build results: >>> total: 137 pass: 121 fail: 16 >>> Failed builds: >>> arm:allmodconfig >>> arm:omap2plus_defconfig >>> arm:exynos_defconfig >>> arm:s5pv210_defconfig >>> powerpc:defconfig >>> powerpc:allmodconfig >>> powerpc:allnoconfig >>> powerpc:ppc64e_defconfig >>> powerpc:cell_defconfig >>> powerpc:maple_defconfig >>> powerpc:ppc6xx_defconfig >>> powerpc:mpc83xx_defconfig >>> powerpc:tqm8xx_defconfig >>> powerpc:85xx/sbc8548_defconfig >>> powerpc:83xx/mpc834x_mds_defconfig >>> powerpc:86xx/sbc8641d_defconfig >>> >>> Culprits are listed below. Copying the patch authors for advice. >>> > > Thanks for reporting it, Guenter. some questions as below: > > - The subject says you were building 3.18 stable kernel, but the PowerPC > related commit was merged to 4.1 kernel. So I assume you were building > 4.1 stable kernel instead. In this case it was 3.18. There were failures in 4.1 as well, but they are different. All builds in 3.18 fail, but only two out of 12 builds in 4.1. For 3.18, this includes both 32 bit and 64 bit builds. > - All above PowerPC configuration failed to build? At least, those > configuration that has (CONFIG_PPC64=y) shouldn't fail because of > the error you pointed. Possibly, but they still fail. Sorry if my report missed the 64 bit error(s). > - Those configuration without (CONFIG_PPC64=y) needs below fix. Could you > please have a try? If it works, I'll post a patch as soon as possible. > > diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c > index b60a67d..25dec0b 100644 > --- a/arch/powerpc/kernel/of_platform.c > +++ b/arch/powerpc/kernel/of_platform.c > @@ -71,8 +71,10 @@ static int of_pci_phb_probe(struct platform_device *dev) > eeh_dev_phb_init_dynamic(phb); > > /* Register devices with EEH */ > +#ifdef CONFIG_EEH > if (dev->dev.of_node->child) > eeh_add_device_tree_early(PCI_DN(dev->dev.of_node)); > +#endif > Looking into a ppc 64 bit log (from a qemu test attempt), I see In file included from arch/powerpc/mm/init_64.c:59:0: ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list [-Werror] static inline void eeh_add_device_early(struct pci_dn *pdn) { } which won't be fixed by the above patch. The build logs are public at http://kerneltests.org/builders. They are typically available for at least 30 days, so feel free to have a look yourself. Thanks, Guenter > Thanks, > Gavin > >>> Guenter >>> >>> --- >>> powerpc: >>> >>> In file included from arch/powerpc/kernel/of_platform.c:30:0: >>> ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list >>> >>> Culprit: "powerpc/eeh: Do probe on pci_dn" >>> >>> --- >>> arm: >>> >>> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': >>> drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' >>> >>> Culprit: "pinctrl: samsung: fix SMP race condition" >>> >>> drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': >>> drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' >>> >>> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': >>> drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' >>> >>> Culprit: "serial/omap: Use the rs485 functions on serial_core" >> >> >> Thanks Guenter. I'll pull both of these out of 3.18 and 4.1 until we can get a proper >> backport since it doesn't seem trivial. >> >> >> Thanks, >> Sasha >> > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 2:47 ` Guenter Roeck @ 2016-03-01 5:06 ` Gavin Shan 2016-03-01 15:19 ` Sasha Levin 0 siblings, 1 reply; 12+ messages in thread From: Gavin Shan @ 2016-03-01 5:06 UTC (permalink / raw) To: Guenter Roeck; +Cc: Gavin Shan, Sasha Levin, stable, Youngmin Nam, Alan Cox [-- Attachment #1: Type: text/plain, Size: 4097 bytes --] On Mon, Feb 29, 2016 at 06:47:40PM -0800, Guenter Roeck wrote: >On 02/29/2016 05:14 PM, Gavin Shan wrote: >>On Mon, Feb 29, 2016 at 07:24:33PM -0500, Sasha Levin wrote: >>>On 02/28/2016 05:45 AM, Guenter Roeck wrote: >>>>Current build results: >>>> total: 137 pass: 121 fail: 16 >>>>Failed builds: >>>> arm:allmodconfig >>>> arm:omap2plus_defconfig >>>> arm:exynos_defconfig >>>> arm:s5pv210_defconfig >>>> powerpc:defconfig >>>> powerpc:allmodconfig >>>> powerpc:allnoconfig >>>> powerpc:ppc64e_defconfig >>>> powerpc:cell_defconfig >>>> powerpc:maple_defconfig >>>> powerpc:ppc6xx_defconfig >>>> powerpc:mpc83xx_defconfig >>>> powerpc:tqm8xx_defconfig >>>> powerpc:85xx/sbc8548_defconfig >>>> powerpc:83xx/mpc834x_mds_defconfig >>>> powerpc:86xx/sbc8641d_defconfig >>>> >>>>Culprits are listed below. Copying the patch authors for advice. >>>> >> >>Thanks for reporting it, Guenter. some questions as below: >> >>- The subject says you were building 3.18 stable kernel, but the PowerPC >> related commit was merged to 4.1 kernel. So I assume you were building >> 4.1 stable kernel instead. > >In this case it was 3.18. There were failures in 4.1 as well, but they are >different. All builds in 3.18 fail, but only two out of 12 builds in 4.1. >For 3.18, this includes both 32 bit and 64 bit builds. > >>- All above PowerPC configuration failed to build? At least, those >> configuration that has (CONFIG_PPC64=y) shouldn't fail because of >> the error you pointed. > >Possibly, but they still fail. Sorry if my report missed the 64 bit error(s). > >>- Those configuration without (CONFIG_PPC64=y) needs below fix. Could you >> please have a try? If it works, I'll post a patch as soon as possible. >> >>diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c >>index b60a67d..25dec0b 100644 >>--- a/arch/powerpc/kernel/of_platform.c >>+++ b/arch/powerpc/kernel/of_platform.c >>@@ -71,8 +71,10 @@ static int of_pci_phb_probe(struct platform_device *dev) >> eeh_dev_phb_init_dynamic(phb); >> >> /* Register devices with EEH */ >>+#ifdef CONFIG_EEH >> if (dev->dev.of_node->child) >> eeh_add_device_tree_early(PCI_DN(dev->dev.of_node)); >>+#endif >> > >Looking into a ppc 64 bit log (from a qemu test attempt), I see > >In file included from arch/powerpc/mm/init_64.c:59:0: >./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list [-Werror] > static inline void eeh_add_device_early(struct pci_dn *pdn) { } > >which won't be fixed by the above patch. > >The build logs are public at http://kerneltests.org/builders. >They are typically available for at least 30 days, so feel free >to have a look yourself. > Yeah, there're more info included in above link. The attached patch would fix the build error. Thanks, Gavin >Thanks, >Guenter > >>Thanks, >>Gavin >> >>>>Guenter >>>> >>>>--- >>>>powerpc: >>>> >>>>In file included from arch/powerpc/kernel/of_platform.c:30:0: >>>>./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list >>>> >>>>Culprit: "powerpc/eeh: Do probe on pci_dn" >>>> >>>>--- >>>>arm: >>>> >>>>drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': >>>>drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' >>>> >>>>Culprit: "pinctrl: samsung: fix SMP race condition" >>>> >>>>drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': >>>>drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' >>>> >>>>drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': >>>>drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' >>>> >>>>Culprit: "serial/omap: Use the rs485 functions on serial_core" >>> >>> >>>Thanks Guenter. I'll pull both of these out of 3.18 and 4.1 until we can get a proper >>>backport since it doesn't seem trivial. >>> >>> >>>Thanks, >>>Sasha >>> >> >> > [-- Attachment #2: 0001-powerpc-eeh-Fix-build-error-caused-by-pci_dn.patch --] [-- Type: text/x-diff, Size: 2384 bytes --] >From 0c43881f78dbdf62ba02364e6306ea271903fc06 Mon Sep 17 00:00:00 2001 From: Gavin Shan <gwshan@linux.vnet.ibm.com> Date: Tue, 1 Mar 2016 16:02:43 +1100 Subject: [PATCH] powerpc/eeh: Fix build error caused by pci_dn MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit eeh.h could be included when we have following condition. Then we run into build error as below: (CONFIG_PPC64 && !CONFIG_EEH) || (!CONFIG_PPC64 && !CONFIG_EEH) In file included from arch/powerpc/kernel/of_platform.c:30:0: ./arch/powerpc/include/asm/eeh.h:344:48: error: ‘struct pci_dn’ \ declared inside parameter list [-Werror] : In file included from arch/powerpc/mm/hash_utils_64.c:49:0: ./arch/powerpc/include/asm/eeh.h:344:48: error: ‘struct pci_dn’ \ declared inside parameter list [-Werror] This fixes the issue by replacing those empty inline functions with macro so that we don't rely on @pci_dn when CONFIG_EEH is disabled. Cc: stable@vger.kernel.org # v4.1+ Fixes: ff57b45 ("powerpc/eeh: Do probe on pci_dn") Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com> --- arch/powerpc/include/asm/eeh.h | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h index c3a2d14..5f7ec12 100644 --- a/arch/powerpc/include/asm/eeh.h +++ b/arch/powerpc/include/asm/eeh.h @@ -339,19 +339,13 @@ static inline int eeh_check_failure(const volatile void __iomem *token) #define eeh_dev_check_failure(x) (0) -static inline void eeh_addr_cache_build(void) { } - -static inline void eeh_add_device_early(struct pci_dn *pdn) { } - -static inline void eeh_add_device_tree_early(struct pci_dn *pdn) { } - -static inline void eeh_add_device_late(struct pci_dev *dev) { } - -static inline void eeh_add_device_tree_late(struct pci_bus *bus) { } - -static inline void eeh_add_sysfs_files(struct pci_bus *bus) { } - -static inline void eeh_remove_device(struct pci_dev *dev) { } +#define eeh_addr_cache_build() +#define eeh_add_device_early(pdn) +#define eeh_add_device_tree_early(pdn) +#define eeh_add_device_late(pdev) +#define eeh_add_device_tree_late(pbus) +#define eeh_add_sysfs_files(pbus) +#define eeh_remove_device(pdev) #define EEH_POSSIBLE_ERROR(val, type) (0) #define EEH_IO_ERROR_VALUE(size) (-1UL) -- 2.1.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 5:06 ` Gavin Shan @ 2016-03-01 15:19 ` Sasha Levin 2016-03-01 23:17 ` Gavin Shan 0 siblings, 1 reply; 12+ messages in thread From: Sasha Levin @ 2016-03-01 15:19 UTC (permalink / raw) To: Gavin Shan, Guenter Roeck; +Cc: stable, Youngmin Nam, Alan Cox On 03/01/2016 12:06 AM, Gavin Shan wrote: > Cc: stable@vger.kernel.org # v4.1+ What about the 3.18 breakages? Is there a different fix for those? Thanks, Sasha ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 15:19 ` Sasha Levin @ 2016-03-01 23:17 ` Gavin Shan 2016-03-06 22:38 ` Gavin Shan 0 siblings, 1 reply; 12+ messages in thread From: Gavin Shan @ 2016-03-01 23:17 UTC (permalink / raw) To: Sasha Levin; +Cc: Gavin Shan, Guenter Roeck, stable, Youngmin Nam, Alan Cox On Tue, Mar 01, 2016 at 10:19:08AM -0500, Sasha Levin wrote: >On 03/01/2016 12:06 AM, Gavin Shan wrote: >> Cc: stable@vger.kernel.org # v4.1+ > >What about the 3.18 breakages? Is there a different fix for those? > This build failure is introduced by commit ff57b45 ("powerpc/eeh: Do probe on pci_dn") which was merged to 4.1 kernel. I don't know why 3.18 stable kernel needs it. If 3.18 stable kernel needs the commit, yes, the attached fix should be put into 3.18 stable kernel as well. Let me know if there're anything else I need to handle. gwshan@gwshan:~/sandbox/linux.main$ git tag --contains ff57b45 v4.1 v4.1-rc1 v4.1-rc2 v4.1-rc3 v4.1-rc4 v4.1-rc5 v4.1-rc6 v4.1-rc7 v4.1-rc8 v4.2 : : Thanks, Gavin > >Thanks, >Sasha > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 23:17 ` Gavin Shan @ 2016-03-06 22:38 ` Gavin Shan 0 siblings, 0 replies; 12+ messages in thread From: Gavin Shan @ 2016-03-06 22:38 UTC (permalink / raw) To: Gavin Shan; +Cc: Sasha Levin, Guenter Roeck, stable, Youngmin Nam, Alan Cox On Wed, Mar 02, 2016 at 10:17:08AM +1100, Gavin Shan wrote: >On Tue, Mar 01, 2016 at 10:19:08AM -0500, Sasha Levin wrote: >>On 03/01/2016 12:06 AM, Gavin Shan wrote: >>> Cc: stable@vger.kernel.org # v4.1+ >> >>What about the 3.18 breakages? Is there a different fix for those? >> > >This build failure is introduced by commit ff57b45 ("powerpc/eeh: >Do probe on pci_dn") which was merged to 4.1 kernel. I don't know >why 3.18 stable kernel needs it. If 3.18 stable kernel needs the >commit, yes, the attached fix should be put into 3.18 stable >kernel as well. > >Let me know if there're anything else I need to handle. > FYI, the patch sent for review/merge: https://patchwork.ozlabs.org/patch/591691/ Thanks, Gavin >gwshan@gwshan:~/sandbox/linux.main$ git tag --contains ff57b45 >v4.1 >v4.1-rc1 >v4.1-rc2 >v4.1-rc3 >v4.1-rc4 >v4.1-rc5 >v4.1-rc6 >v4.1-rc7 >v4.1-rc8 >v4.2 > : > : > >Thanks, >Gavin > >> >>Thanks, >>Sasha >> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 0:24 ` Sasha Levin 2016-03-01 1:14 ` Gavin Shan @ 2016-03-02 4:31 ` Guenter Roeck 1 sibling, 0 replies; 12+ messages in thread From: Guenter Roeck @ 2016-03-02 4:31 UTC (permalink / raw) To: Sasha Levin, stable; +Cc: Youngmin Nam, Gavin Shan, Alan Cox On 02/29/2016 04:24 PM, Sasha Levin wrote: > On 02/28/2016 05:45 AM, Guenter Roeck wrote: >> Current build results: >> total: 137 pass: 121 fail: 16 >> Failed builds: >> arm:allmodconfig >> arm:omap2plus_defconfig >> arm:exynos_defconfig >> arm:s5pv210_defconfig >> powerpc:defconfig >> powerpc:allmodconfig >> powerpc:allnoconfig >> powerpc:ppc64e_defconfig >> powerpc:cell_defconfig >> powerpc:maple_defconfig >> powerpc:ppc6xx_defconfig >> powerpc:mpc83xx_defconfig >> powerpc:tqm8xx_defconfig >> powerpc:85xx/sbc8548_defconfig >> powerpc:83xx/mpc834x_mds_defconfig >> powerpc:86xx/sbc8641d_defconfig >> >> Culprits are listed below. Copying the patch authors for advice. >> >> Guenter >> >> --- >> powerpc: >> >> In file included from arch/powerpc/kernel/of_platform.c:30:0: >> ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list >> >> Culprit: "powerpc/eeh: Do probe on pci_dn" >> >> --- >> arm: >> >> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': >> drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' >> >> Culprit: "pinctrl: samsung: fix SMP race condition" >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': >> drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': >> drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' >> >> Culprit: "serial/omap: Use the rs485 functions on serial_core" > > > Thanks Guenter. I'll pull both of these out of 3.18 and 4.1 until we can get a proper > backport since it doesn't seem trivial. > Hi Sasha, the ppc error is now gone, as is the gpio error. 3.18 builds still fail due to the rs485 error, though. Guenter ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-02-28 10:45 Build errors in v3.18-stable-queue Guenter Roeck 2016-03-01 0:24 ` Sasha Levin @ 2016-03-01 11:12 ` Youngmin Nam 2016-03-01 15:18 ` Sasha Levin 1 sibling, 1 reply; 12+ messages in thread From: Youngmin Nam @ 2016-03-01 11:12 UTC (permalink / raw) To: Guenter Roeck, stable; +Cc: Sasha Levin, Gavin Shan, Alan Cox, Linus Walleij On 2016년 02월 28일 19:45, Guenter Roeck wrote: > Current build results: > total: 137 pass: 121 fail: 16 > Failed builds: > arm:allmodconfig > arm:omap2plus_defconfig > arm:exynos_defconfig > arm:s5pv210_defconfig > powerpc:defconfig > powerpc:allmodconfig > powerpc:allnoconfig > powerpc:ppc64e_defconfig > powerpc:cell_defconfig > powerpc:maple_defconfig > powerpc:ppc6xx_defconfig > powerpc:mpc83xx_defconfig > powerpc:tqm8xx_defconfig > powerpc:85xx/sbc8548_defconfig > powerpc:83xx/mpc834x_mds_defconfig > powerpc:86xx/sbc8641d_defconfig > > Culprits are listed below. Copying the patch authors for advice. > > Guenter > > --- > powerpc: > > In file included from arch/powerpc/kernel/of_platform.c:30:0: > ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list > > Culprit: "powerpc/eeh: Do probe on pci_dn" > > --- > arm: > > drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': > drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' > > Culprit: "pinctrl: samsung: fix SMP race condition" > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': > drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': > drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' > > Culprit: "serial/omap: Use the rs485 functions on serial_core" Thanks Guenter. I think below Linus' patch will also need to fix the build error. commit b08ea35a3296ee25c4cb53a977b752266dafa2c2 Author: Linus Walleij <linus.walleij@linaro.org> Date: Thu Dec 3 15:14:13 2015 +0100 gpio: add a data pointer to gpio_chip This adds a void * pointer to gpio_chip so that driver can assign and retrieve some states. This is done to get rid of container_of() calls for gpio_chips embedded inside state containers, so we can remove the need to have the gpio_chip or later (planned) struct gpio_device be dynamically allocated at registration time, so that its struct device can be properly reference counted and not bound to its parent device (e.g. a platform_device) but instead live on after unregistration if it is opened by e.g. a char device or sysfs. The data is added with the new function gpiochip_add_data() and for compatibility we add static inline wrapper function gpiochip_add() that will call gpiochip_add_data() with NULL as argument. The latter will be removed once we have exorcised gpiochip_add() from the kernel. gpiochip_get_data() is added as a static inline accessor for drivers to quickly get their data out. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Build errors in v3.18-stable-queue 2016-03-01 11:12 ` Youngmin Nam @ 2016-03-01 15:18 ` Sasha Levin 0 siblings, 0 replies; 12+ messages in thread From: Sasha Levin @ 2016-03-01 15:18 UTC (permalink / raw) To: Youngmin Nam, Guenter Roeck, stable; +Cc: Gavin Shan, Alan Cox, Linus Walleij On 03/01/2016 06:12 AM, Youngmin Nam wrote: > On 2016년 02월 28일 19:45, Guenter Roeck wrote: >> Current build results: >> total: 137 pass: 121 fail: 16 >> Failed builds: >> arm:allmodconfig >> arm:omap2plus_defconfig >> arm:exynos_defconfig >> arm:s5pv210_defconfig >> powerpc:defconfig >> powerpc:allmodconfig >> powerpc:allnoconfig >> powerpc:ppc64e_defconfig >> powerpc:cell_defconfig >> powerpc:maple_defconfig >> powerpc:ppc6xx_defconfig >> powerpc:mpc83xx_defconfig >> powerpc:tqm8xx_defconfig >> powerpc:85xx/sbc8548_defconfig >> powerpc:83xx/mpc834x_mds_defconfig >> powerpc:86xx/sbc8641d_defconfig >> >> Culprits are listed below. Copying the patch authors for advice. >> >> Guenter >> >> --- >> powerpc: >> >> In file included from arch/powerpc/kernel/of_platform.c:30:0: >> ./arch/powerpc/include/asm/eeh.h:344:48: error: 'struct pci_dn' declared inside parameter list >> >> Culprit: "powerpc/eeh: Do probe on pci_dn" >> >> --- >> arm: >> >> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpio_set': >> drivers/pinctrl/samsung/pinctrl-samsung.c:551:9: error: implicit declaration of function 'gpiochip_get_data' >> >> Culprit: "pinctrl: samsung: fix SMP race condition" >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_stop_tx': >> drivers/tty/serial/omap-serial.c:318:10: error: 'struct uart_port' has no member named 'rs485' >> >> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': >> drivers/tty/serial/omap-serial.c:1683:10: error: 'struct uart_port' has no member named 'rs485_config' >> >> Culprit: "serial/omap: Use the rs485 functions on serial_core" > > Thanks Guenter. I think below Linus' patch will also need to fix the build error. > > commit b08ea35a3296ee25c4cb53a977b752266dafa2c2 > Author: Linus Walleij <linus.walleij@linaro.org> > Date: Thu Dec 3 15:14:13 2015 +0100 > > gpio: add a data pointer to gpio_chip > > This adds a void * pointer to gpio_chip so that driver can > assign and retrieve some states. This is done to get rid of > container_of() calls for gpio_chips embedded inside state > containers, so we can remove the need to have the gpio_chip > or later (planned) struct gpio_device be dynamically allocated > at registration time, so that its struct device can be properly > reference counted and not bound to its parent device (e.g. > a platform_device) but instead live on after unregistration > if it is opened by e.g. a char device or sysfs. > > The data is added with the new function gpiochip_add_data() > and for compatibility we add static inline wrapper function > gpiochip_add() that will call gpiochip_add_data() with > NULL as argument. The latter will be removed once we have > exorcised gpiochip_add() from the kernel. > > gpiochip_get_data() is added as a static inline accessor > for drivers to quickly get their data out. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Hi Youngmin, This won't be enough as that commit merely adds a field but doesn't add any usages of that field, so adding that patch into -stable would "fix" the build error but would break the device itself. Thanks, Sasha ^ permalink raw reply [flat|nested] 12+ messages in thread
* build errors in v3.18-stable-queue @ 2015-08-25 19:24 Guenter Roeck 0 siblings, 0 replies; 12+ messages in thread From: Guenter Roeck @ 2015-08-25 19:24 UTC (permalink / raw) To: Sasha Levin; +Cc: stable Build results: total: 136 pass: 100 fail: 36 Failed builds: alpha:allmodconfig arm:allmodconfig arm:imx_v6_v7_defconfig arm:ixp4xx_defconfig arm:multi_v5_defconfig arm:rpc_defconfig arm:axm55xx_defconfig arm:vexpress_defconfig arm:imx_v4_v5_defconfig arm:shmobile_defconfig arm:orion5x_defconfig arm:cm_x2xx_defconfig arm64:allmodconfig avr32:defconfig ia64:defconfig mips:allmodconfig mips:nlm_xlp_defconfig mips:cavium_octeon_defconfig parisc:allmodconfig parisc:generic-32bit_defconfig parisc:generic-64bit_defconfig powerpc:defconfig powerpc:allmodconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig powerpc:maple_defconfig powerpc:ppc6xx_defconfig powerpc:mpc83xx_defconfig sparc32:allmodconfig sparc64:allmodconfig tile:tilegx_defconfig unicore32:defconfig x86_64:defconfig x86_64:allyesconfig x86_64:allmodconfig xtensa:allmodconfig Error log: drivers/ata/libata-core.c:4243:32: error: 'ATA_HORKAGE_NOTRIM' undeclared here (not in a function) make[2]: *** [drivers/ata/libata-core.o] Error 1 Guenter ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-03-06 22:39 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-28 10:45 Build errors in v3.18-stable-queue Guenter Roeck 2016-03-01 0:24 ` Sasha Levin 2016-03-01 1:14 ` Gavin Shan 2016-03-01 2:47 ` Guenter Roeck 2016-03-01 5:06 ` Gavin Shan 2016-03-01 15:19 ` Sasha Levin 2016-03-01 23:17 ` Gavin Shan 2016-03-06 22:38 ` Gavin Shan 2016-03-02 4:31 ` Guenter Roeck 2016-03-01 11:12 ` Youngmin Nam 2016-03-01 15:18 ` Sasha Levin -- strict thread matches above, loose matches on Subject: below -- 2015-08-25 19:24 build " Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).