From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:34795 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbcCMD6t (ORCPT ); Sat, 12 Mar 2016 22:58:49 -0500 Received: by mail-pa0-f45.google.com with SMTP id fe3so114457518pab.1 for ; Sat, 12 Mar 2016 19:58:49 -0800 (PST) Subject: Re: [PATCH] block: don't optimize for non-cloned bio in bio_get_last_bvec() To: Ming Lei , linux-kernel@vger.kernel.org References: <1457794579-6125-1-git-send-email-ming.lei@canonical.com> Cc: linux-block@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Kent Overstreet , stable@vger.kernel.org From: Jens Axboe Message-ID: <56E4E575.5020303@kernel.dk> Date: Sat, 12 Mar 2016 20:58:45 -0700 MIME-Version: 1.0 In-Reply-To: <1457794579-6125-1-git-send-email-ming.lei@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 03/12/2016 07:56 AM, Ming Lei wrote: > For !BIO_CLONED bio, we can use .bi_vcnt safely, but it > doesn't mean we can just simply return .bi_io_vec[.bi_vcnt - 1] > because the start postion may have been moved in the middle of > the bvec, such as splitting in the middle of bvec. Added and tested. -- Jens Axboe