From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f178.google.com ([209.85.217.178]:32918 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030269AbcCQL7N (ORCPT ); Thu, 17 Mar 2016 07:59:13 -0400 Received: by mail-lb0-f178.google.com with SMTP id oe12so66990903lbc.0 for ; Thu, 17 Mar 2016 04:59:12 -0700 (PDT) Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts To: Vineet Gupta , Alexey Brodkin References: <1458207712-29435-1-git-send-email-abrodkin@synopsys.com> <56EA8DCC.8070308@cogentembedded.com> <1458214678.14496.15.camel@synopsys.com> Cc: "robh@kernel.org" , "preid@electromag.com.au" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "davem@davemloft.net" From: Sergei Shtylyov Message-ID: <56EA9C0D.1090000@cogentembedded.com> Date: Thu, 17 Mar 2016 14:59:09 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hello. On 3/17/2016 2:41 PM, Vineet Gupta wrote: >>>> Following commit broke DW GMAC functionality on AXS10x boards: >>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 >>> Note that scripts/checkpatch.pl now enforces certain format for citing >>> commits: commit <12-digit SHA1> (""). >> Frankly I haven't run that patch through checkpatch due to patch >> simplicity. >> >> But I'll try to not do any assumptions from now on and will try to >> use checkpatch for each and every thing I send :) >> >> Thanks for spotting all his! >> Sorry for not reporting everything on the 1st review. >> -Alexey > > Sergei, do you mind providing a Ack/Reviewed-by on the patch below > Reviewed-by: Sergei Shtylyov The patch here is white space damaged however: tabs were converted to spaces. :-( MBR, Sergei