From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:14284 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752844AbcCYDDx (ORCPT ); Thu, 24 Mar 2016 23:03:53 -0400 Subject: Re: [PATCH 03/10] USB: uas: Reduce can_queue to MAX_CMNDS Cc: Hans de Goede , stable@vger.kernel.org References: <1458874746-958-1-git-send-email-baolu.lu@linux.intel.com> <1458874746-958-3-git-send-email-baolu.lu@linux.intel.com> From: Lu Baolu Message-ID: <56F4AA94.4040207@linux.intel.com> Date: Fri, 25 Mar 2016 11:03:48 +0800 MIME-Version: 1.0 In-Reply-To: <1458874746-958-3-git-send-email-baolu.lu@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: unlisted-recipients:; (no To-header on input) Sender: stable-owner@vger.kernel.org List-ID: I am sorry. This email was sent out due to an incorrect operation. Please ignore it. I am sorry for disturbing you. Best Regards, Baolu On 03/25/2016 10:58 AM, Lu Baolu wrote: > From: Hans de Goede > > The uas driver can never queue more then MAX_CMNDS (- 1) tags and tags > are shared between luns, so there is no need to claim that we can_queue > some random large number. > > Not claiming that we can_queue 65536 commands, fixes the uas driver > failing to initialize while allocating the tag map with a "Page allocation > failure (order 7)" error on systems which have been running for a while > and thus have fragmented memory. > > Cc: stable@vger.kernel.org > Reported-and-tested-by: Yves-Alexis Perez > Signed-off-by: Hans de Goede > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/storage/uas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c > index 44b096c..13e4cc3 100644 > --- a/drivers/usb/storage/uas.c > +++ b/drivers/usb/storage/uas.c > @@ -836,7 +836,7 @@ static struct scsi_host_template uas_host_template = { > .slave_configure = uas_slave_configure, > .eh_abort_handler = uas_eh_abort_handler, > .eh_bus_reset_handler = uas_eh_bus_reset_handler, > - .can_queue = 65536, /* Is there a limit on the _host_ ? */ > + .can_queue = MAX_CMNDS, > .this_id = -1, > .sg_tablesize = SG_NONE, > .skip_settle_delay = 1,