Re: [PATCH 1/3] staging: comedi: das1800: fix possible NULL dereference

[Ian Abbott <abbotti@mev.co.uk>]

On 08/04/16 18:14, H Hartley Sweeten wrote:
> DMA is optional with this driver. If it was not enabled the devpriv->dma
> pointer will be NULL.
>
> Fix the possible NULL pointer dereference when trying to disable the DMA
> channels in das1800_ai_cancel() and tidy up the comments to fix the
> checkpatch.pl issues:
> WARNING: line over 80 characters
>
> It's probably harmless in das1800_ai_setup_dma() because the 'desc' pointer
> will not be used if DMA is disabled but fix it there also.
>
> Fixes: 99dfc3357e98 ("staging: comedi: das1800: remove depends on ISA_DMA_API limitation")
> Cc: <stable@vger.kernel.org> # 4.0+
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/das1800.c | 22 +++++++++++++---------
>   1 file changed, 13 insertions(+), 9 deletions(-)
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

(I've already reviewed the other two.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-