From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp123.iad3a.emailsrvr.com ([173.203.187.123]:42273 "EHLO smtp123.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbcDKJlj (ORCPT ); Mon, 11 Apr 2016 05:41:39 -0400 Subject: Re: [PATCH 1/3] staging: comedi: das1800: fix possible NULL dereference To: H Hartley Sweeten , devel@linuxdriverproject.org References: <1460135700-17749-1-git-send-email-hsweeten@visionengravers.com> <1460135700-17749-2-git-send-email-hsweeten@visionengravers.com> Cc: gregkh@linuxfoundation.org, "# 4 . 0+" From: Ian Abbott Message-ID: <570B6EFC.2040802@mev.co.uk> Date: Mon, 11 Apr 2016 10:31:40 +0100 MIME-Version: 1.0 In-Reply-To: <1460135700-17749-2-git-send-email-hsweeten@visionengravers.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 08/04/16 18:14, H Hartley Sweeten wrote: > DMA is optional with this driver. If it was not enabled the devpriv->dma > pointer will be NULL. > > Fix the possible NULL pointer dereference when trying to disable the DMA > channels in das1800_ai_cancel() and tidy up the comments to fix the > checkpatch.pl issues: > WARNING: line over 80 characters > > It's probably harmless in das1800_ai_setup_dma() because the 'desc' pointer > will not be used if DMA is disabled but fix it there also. > > Fixes: 99dfc3357e98 ("staging: comedi: das1800: remove depends on ISA_DMA_API limitation") > Cc: # 4.0+ > Signed-off-by: H Hartley Sweeten > Cc: Ian Abbott > Cc: Greg Kroah-Hartman > --- > drivers/staging/comedi/drivers/das1800.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > Thanks! Reviewed-by: Ian Abbott (I've already reviewed the other two.) -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-