Build failures in v3.18-stable-queue (x86, s390)

Build failures in v3.18-stable-queue (x86, s390)

[Guenter Roeck]

i386, x86_64 (all builds):

make[3]: *** No rule to make target 'arch/x86/kernel/cpu/perf_event_intel_cqm.o', needed by 'arch/x86/kernel/cpu/built-in.o'.

Bisected to commit "perf/x86/intel: Fix Makefile to actually build the cqm driver".

s390:allmodconfig:

arch/s390/pci/pci.c: In function 'pci_base_init':
arch/s390/pci/pci.c:843:2: error: call to '__compiletime_assert_844' declared with attribute error:
	BUILD_BUG_ON failed: !is_power_of_2(__alignof__(struct zpci_fmb)) || __alignof__(struct zpci_fmb) < sizeof(struct zpci_fmb)

Bisected to commit "s390/pci: enforce fmb page boundary rule".

Copying the original authors for feedback.

Guenter

Re: Build failures in v3.18-stable-queue (x86, s390)

[Sebastian Ott]

On Thu, 14 Apr 2016, Guenter Roeck wrote:
> s390:allmodconfig:
> 
> arch/s390/pci/pci.c: In function 'pci_base_init':
> arch/s390/pci/pci.c:843:2: error: call to '__compiletime_assert_844' declared
> with attribute error:
> 	BUILD_BUG_ON failed: !is_power_of_2(__alignof__(struct zpci_fmb)) ||
> 	__alignof__(struct zpci_fmb) < sizeof(struct zpci_fmb)
> 
> Bisected to commit "s390/pci: enforce fmb page boundary rule".

Do you have a pointer to a git tree or to the 3.18 version of that patch.
I don't see how that BUILD_BUG_ON should be triggered since both the size
and alignment of this structure are 64 bytes.

Regards,
Sebastian

Re: Build failures in v3.18-stable-queue (x86, s390)

[Guenter Roeck]

On 04/14/2016 07:03 AM, Sebastian Ott wrote:
> On Thu, 14 Apr 2016, Guenter Roeck wrote:
>> s390:allmodconfig:
>>
>> arch/s390/pci/pci.c: In function 'pci_base_init':
>> arch/s390/pci/pci.c:843:2: error: call to '__compiletime_assert_844' declared
>> with attribute error:
>> 	BUILD_BUG_ON failed: !is_power_of_2(__alignof__(struct zpci_fmb)) ||
>> 	__alignof__(struct zpci_fmb) < sizeof(struct zpci_fmb)
>>
>> Bisected to commit "s390/pci: enforce fmb page boundary rule".
>
> Do you have a pointer to a git tree or to the 3.18 version of that patch.
> I don't see how that BUILD_BUG_ON should be triggered since both the size
> and alignment of this structure are 64 bytes.
>

Try git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git,
branch stable-queue-import-3.18. git describe should report v3.18.30-167-gfcc3f16
for the tip of the branch (at least that is what my builder picked up).

Thanks,
Guenter

Re: Build failures in v3.18-stable-queue (x86, s390)

[Sebastian Ott]

On Thu, 14 Apr 2016, Guenter Roeck wrote:
> On 04/14/2016 07:03 AM, Sebastian Ott wrote:
> > On Thu, 14 Apr 2016, Guenter Roeck wrote:
> > > s390:allmodconfig:
> > >
> > > arch/s390/pci/pci.c: In function 'pci_base_init':
> > > arch/s390/pci/pci.c:843:2: error: call to '__compiletime_assert_844'
> > > declared
> > > with attribute error:
> > >  BUILD_BUG_ON failed: !is_power_of_2(__alignof__(struct zpci_fmb)) ||
> > >  __alignof__(struct zpci_fmb) < sizeof(struct zpci_fmb)
> > >
> > > Bisected to commit "s390/pci: enforce fmb page boundary rule".
> >
> > Do you have a pointer to a git tree or to the 3.18 version of that patch.
> > I don't see how that BUILD_BUG_ON should be triggered since both the size
> > and alignment of this structure are 64 bytes.
> >
> 
> Try git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git,
> branch stable-queue-import-3.18. git describe should report
> v3.18.30-167-gfcc3f16
> for the tip of the branch (at least that is what my builder picked up).
> 

commit 6001018ae "s390/pci: extract software counters from fmb"
is missing here. Putting that one before "s390/pci: enforce fmb page 
boundary rule" will fix the build failure.

Sebastian

Re: Build failures in v3.18-stable-queue (x86, s390)

[Sasha Levin]

On 04/14/2016 09:44 AM, Guenter Roeck wrote:
> i386, x86_64 (all builds):
> 
> make[3]: *** No rule to make target 'arch/x86/kernel/cpu/perf_event_intel_cqm.o', needed by 'arch/x86/kernel/cpu/built-in.o'.
> 
> Bisected to commit "perf/x86/intel: Fix Makefile to actually build the cqm driver".
> 
> s390:allmodconfig:
> 
> arch/s390/pci/pci.c: In function 'pci_base_init':
> arch/s390/pci/pci.c:843:2: error: call to '__compiletime_assert_844' declared with attribute error:
>     BUILD_BUG_ON failed: !is_power_of_2(__alignof__(struct zpci_fmb)) || __alignof__(struct zpci_fmb) < sizeof(struct zpci_fmb)
> 
> Bisected to commit "s390/pci: enforce fmb page boundary rule".
> 
> Copying the original authors for feedback.

Fixed both and re-pushed. Thanks all!