From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:3040 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbcDRKCT (ORCPT ); Mon, 18 Apr 2016 06:02:19 -0400 Subject: Re: [PATCH] drm/i915: Avoid stalling on pending flips for legacy cursor updates To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <1460922166-20292-1-git-send-email-chris@chris-wilson.co.uk> Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Daniel Vetter , Jani Nikula , stable@vger.kernel.org From: Maarten Lankhorst Message-ID: <5714B0A7.8030207@linux.intel.com> Date: Mon, 18 Apr 2016 12:02:15 +0200 MIME-Version: 1.0 In-Reply-To: <1460922166-20292-1-git-send-email-chris@chris-wilson.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: Op 17-04-16 om 21:42 schreef Chris Wilson: > The legacy cursor ioctl expects to be asynchronous with respect to other > screen updates, in particular page flips. As X updates the cursor from a > signal context, if the cursor blocks then it will stall both the input > and output chains causing bad stuttering and horrible UX. > > Reported-and-tested-by: Rafael Ristovski > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94980 > Fixes: 5008e874edd34 ("drm/i915: Make wait_for_flips interruptible.") > Suggested-by: Maarten Lankhorst > Signed-off-by: Chris Wilson > Cc: Maarten Lankhorst > Cc: Ville Syrjälä > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/intel_display.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 4cca155376be..c5b9687091f4 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -13446,6 +13446,9 @@ static int intel_atomic_prepare_commit(struct drm_device *dev, > } > > for_each_crtc_in_state(state, crtc, crtc_state, i) { > + if (state->legacy_cursor_update) > + continue; > + > ret = intel_crtc_wait_for_pending_flips(crtc); > if (ret) > return ret; Reviewed-by: Maarten Lankhorst