From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:36013 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbcD0JJA (ORCPT ); Wed, 27 Apr 2016 05:09:00 -0400 Received: by mail-wm0-f67.google.com with SMTP id w143so10845793wmw.3 for ; Wed, 27 Apr 2016 02:08:59 -0700 (PDT) Subject: Re: [patch added to 3.12-stable] qmi_wwan: add Sierra Wireless MC74xx/EM74xx To: =?UTF-8?Q?Bj=c3=b8rn_Mork?= References: <1461133871-7390-1-git-send-email-jslaby@suse.cz> <1461133871-7390-12-git-send-email-jslaby@suse.cz> <87mvoo60z6.fsf@nemi.mork.no> Cc: stable@vger.kernel.org, "David S . Miller" From: Jiri Slaby Message-ID: <572081A8.2010901@suse.cz> Date: Wed, 27 Apr 2016 11:08:56 +0200 MIME-Version: 1.0 In-Reply-To: <87mvoo60z6.fsf@nemi.mork.no> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 04/20/2016, 12:14 PM, Bjørn Mork wrote: >> --- a/drivers/net/usb/qmi_wwan.c >> +++ b/drivers/net/usb/qmi_wwan.c >> @@ -747,6 +747,10 @@ static const struct usb_device_id products[] = { >> {QMI_FIXED_INTF(0x1199, 0x9056, 8)}, /* Sierra Wireless Modem */ >> {QMI_FIXED_INTF(0x1199, 0x9057, 8)}, >> {QMI_FIXED_INTF(0x1199, 0x9061, 8)}, /* Sierra Wireless Modem */ >> + {QMI_FIXED_INTF(0x1199, 0x9070, 8)}, /* Sierra Wireless MC74xx/EM74xx */ >> + {QMI_FIXED_INTF(0x1199, 0x9070, 10)}, /* Sierra Wireless MC74xx/EM74xx */ >> + {QMI_FIXED_INTF(0x1199, 0x9071, 8)}, /* Sierra Wireless MC74xx/EM74xx */ >> + {QMI_FIXED_INTF(0x1199, 0x9071, 10)}, /* Sierra Wireless MC74xx/EM74xx */ > > This is of course harmless, but those devices won't actually work > without this fix: > > 93725149794d ("net: qmi_wwan: MDM9x30 specific power management") > > > And I'm not sure that one is appropriate for stable? I did consider it > more of a feature than a bugfix myself. But that's up to you to decide > of course. Yes, all of these are "features", but they still satisfy the stable rules though ("New device IDs and quirks are also accepted".) And given it is small enough and in upstream for a while I decided to put that in in the end. thanks, -- js suse labs