From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-wm0-f51.google.com ([74.125.82.51]:36348 "EHLO
	mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758356AbcFAPgA (ORCPT
	<rfc822;stable@vger.kernel.org>); Wed, 1 Jun 2016 11:36:00 -0400
Subject: Re: [PATCH] IB/core: Fix different types mix in ib_device_cap_flags
 structure values
To: Max Gurtovoy <maxg@mellanox.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Leon Romanovsky <leon@kernel.org>
References: <1464602994-21226-1-git-send-email-maxg@mellanox.com>
 <08df9022-e575-da0d-c76d-a28185c9db2d@sandisk.com>
 <20160531171306.GA6618@obsidianresearch.com> <20160531173033.GC7477@leon.nu>
 <13f16fdf-e1d2-0baa-abe1-6423d2196b72@sandisk.com>
 <20160531181223.GE7477@leon.nu> <20160531182100.GC21834@obsidianresearch.com>
 <20160531185432.GF7477@leon.nu> <20160531193956.GD21834@obsidianresearch.com>
 <574ECF44.3070003@mellanox.com>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>, matanb@mellanox.com,
	linux-rdma@vger.kernel.org, stable@vger.kernel.org
From: Sagi Grimberg <sagi@grimberg.me>
Message-ID: <574F00DC.5000002@grimberg.me>
Date: Wed, 1 Jun 2016 18:35:56 +0300
MIME-Version: 1.0
In-Reply-To: <574ECF44.3070003@mellanox.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>


>> Which is clearly wrong. This is because signed int becomes sign
>> extended when converted to uint64_t, corrupting the upper bits.
>>
>> Since adding the ULL's doesn't make the enum constants have uniform
>> type I would not bother with the churn.
>
> tested this with single casting to IB_DEVICE_ON_DEMAND_PAGING (1 << 31)
> to (1ULL << 31). works fine.
> I'll send another patch today.

Good to know, thanks Max.