From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from eusmtp01.atmel.com ([212.144.249.242]:23442 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932344AbcFBJoP (ORCPT
	<rfc822;stable@vger.kernel.org>); Thu, 2 Jun 2016 05:44:15 -0400
Subject: Re: [PATCH] drm: atmel-hlcdc: actually disable scaling when no
 scaling is required
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>
References: <1464781370-19277-1-git-send-email-boris.brezillon@free-electrons.com>
CC: <linux-arm-kernel@lists.infradead.org>, <stable@vger.kernel.org>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Message-ID: <574FFFEA.5060309@atmel.com>
Date: Thu, 2 Jun 2016 11:44:10 +0200
MIME-Version: 1.0
In-Reply-To: <1464781370-19277-1-git-send-email-boris.brezillon@free-electrons.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Le 01/06/2016 13:42, Boris Brezillon a �crit :
> The driver is only enabling scaling, but never disabling it, thus, if you
> enable the scaling feature once it stays enabled forever.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Alex Vazquez <avazquez.dev@gmail.com>
> Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
> Cc: <stable@vger.kernel.org>

Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks!

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index aef3ca8..016c191 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
>  
>  		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
>  					     factor_reg);
> +	} else {
> +		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
>  	}
>  }
>  
> 


-- 
Nicolas Ferre