Re: [PATCH v4] drm: Only create a cmdline mode if no probed modes match

Ville Syrjälä
2016-06-02T11:31:00Z

On Thu, Jun 02, 2016 at 11:52:17AM +0100, Chris Wilson wrote:
> On Thu, Jun 02, 2016 at 11:38:26AM +0200, Radek Dostï¿½l wrote:
> > On 06/01/2016 11:50 AM, Chris Wilson wrote:
> > >Fixes regression from
> > >
> > >commit eaf99c749d43ae74ac7ffece5512f3c73f01dfd2
> > >Author: Chris Wilson<chris@chris-wilson.co.uk>
> > >Date: Wed Aug 6 10:08:32 2014 +0200
> > >
> > > drm: Perform cmdline mode parsing during connector initialisation
> > >
> > >that breaks HDMI output on BeagleBone Black with LG TV (model 19LS4R-ZA).
> >
> > please remove this from the commit message. The original bug is no
> > longer reproducible with 4.7-rc1
>
> If there's no motivation for the patch anymore, it can just wither away
> in one of my old trees.
>
> Does anyone care about pruning the autogenerated video= mode if a probed
> one matches? Presumably, it is still visible to userspace and switching
> to it will cause the same issue as before? Or was it always a driver
> bug (failing to set the mode)?

IMO the patch makes total sense even if it's not needed for this
particular bug. Feel free to add

Reviewed-by: Ville Syrjï¿½lï¿½ <ville.syrjala@linux.intel.com>

--
Ville Syrjï¿½lï¿½
Intel OTC