From: Sasha Levin <sasha.levin@oracle.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [added to the 4.1 stable tree] powerpc/iommu: Remove the dependency on EEH struct in DDW mechanism
Date: Fri, 3 Jun 2016 22:52:48 -0400 [thread overview]
Message-ID: <57524280.2030606@oracle.com> (raw)
In-Reply-To: <201606040233.u542T0jY033418@mx0a-001b2d01.pphosted.com>
On 06/03/2016 10:33 PM, Guilherme G. Piccoli wrote:
> On 06/03/2016 06:36 PM, Sasha Levin wrote:
>> From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
>>
>> This patch has been added to the 4.1 stable tree. If you have any
>> objections, please let us know.
>>
>> ===============
>>
>> [ Upstream commit 8445a87f7092bc8336ea1305be9306f26b846d93 ]
>>
>> Commit 39baadbf36ce ("powerpc/eeh: Remove eeh information from pci_dn")
>> changed the pci_dn struct by removing its EEH-related members.
>> As part of this clean-up, DDW mechanism was modified to read the device
>> configuration address from eeh_dev struct.
>>
>> As a consequence, now if we disable EEH mechanism on kernel command-line
>> for example, the DDW mechanism will fail, generating a kernel oops by
>> dereferencing a NULL pointer (which turns to be the eeh_dev pointer).
>>
>> This patch just changes the configuration address calculation on DDW
>> functions to a manual calculation based on pci_dn members instead of
>> using eeh_dev-based address.
>>
>> No functional changes were made. This was tested on pSeries, both
>> in PHyp and qemu guest.
>>
>> Fixes: 39baadbf36ce ("powerpc/eeh: Remove eeh information from pci_dn")
>> Cc: stable@vger.kernel.org # v3.4+
>> Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>
>
> Hi Sasha, thanks for letting me know.
>
> Unfortunately, this patch has an issue; the proposed fix is simple and was already sent to linuxppc-dev list by Gavin Shan.
>
> Link to the proposed fix (already tested): https://patchwork.ozlabs.org/patch/626492
>
> Thanks, and sorry for the inconvenience.
> Cheers,
>
>
> Guilherme
Hey Guilherme,
Since the fix isn't in Linus's tree yet, I'll revert this commit from both 4.1 and 3.18
and re-add it into the next release.
Thanks for the report.
Thanks,
Sasha
next prev parent reply other threads:[~2016-06-04 2:53 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 21:34 [added to the 4.1 stable tree] perf/x86/intel/pt: Generate PMI in the STOP region as well Sasha Levin
2016-06-03 21:34 ` [added to the 4.1 stable tree] ath10k: fix firmware assert in monitor mode Sasha Levin
2016-06-03 21:34 ` [added to the 4.1 stable tree] ath10k: fix debugfs pktlog_filter write Sasha Levin
2016-06-03 21:34 ` [added to the 4.1 stable tree] regulator: core: Use class device list for regulator_list in late init Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] regulator: Try to resolve regulators supplies on registration Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ath5k: Change led pin configuration for compaq c700 laptop Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] xfs: disallow rw remount on fs with unknown ro-compat features Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] xfs: Don't wrap growfs AGFL indexes Sasha Levin
2016-06-03 23:05 ` Dave Chinner
2016-06-03 23:10 ` Sasha Levin
2016-06-04 0:02 ` Dave Chinner
2016-06-06 22:57 ` Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] rtlwifi: rtl8723be: Fix module parameter initialization Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] rtlwifi: rtl8723be: Add antenna select module parameter Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] rtlwifi: btcoexist: Implement antenna selection Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] drm/gma500: Fix possible out of bounds read Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] Bluetooth: vhci: fix open_timeout vs. hdev race Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] Bluetooth: vhci: purge unhandled skbs Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] cpuidle: Indicate when a device has been unregistered Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] mfd: intel_quark_i2c_gpio: load gpio driver first Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] [media] media: v4l2-compat-ioctl32: fix missing reserved field copy in put_v4l2_create32 Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: gadget: mass_storage: Free buffers if create lun fails Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: gadget: mass_storage: Fix freeing luns sysfs implementation Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: gadget: mass_storage: Use static array for luns Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: f_mass_storage: test whether thread is running before starting another Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] hwmon: (ads7828) Enable internal reference Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] Bluetooth: vhci: Fix race at creating hci device Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] powerpc/book3s64: Fix branching to OOL handlers in relocatable kernel Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] PM / Runtime: Fix error path in pm_runtime_force_resume() Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] crypto: s5p-sss - Remove useless hash interrupt handler Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] crypto: s5p-sss - Fix missed interrupts when working with 8 kB blocks Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ath9k: Add a module parameter to invert LED polarity Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 cards Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] pinctrl: exynos5440: Use off-stack memory for pinctrl_gpio_range Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: core: hub: hub_port_init lock controller instead of bus Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] serial: 8250_pci: fix divide error bug if baud rate is 0 Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] TTY: n_gsm, fix false positive WARN_ON Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] staging: comedi: das1800: fix possible NULL dereference Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] arm/arm64: KVM: Enforce Break-Before-Make on Stage-2 page tables Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] aacraid: Relinquish CPU during timeout wait Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] aacraid: Fix for aac_command_thread hang Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] aacraid: Fix for KDUMP driver hang Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ext4: fix hang when processing corrupted orphaned inode list Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ext4: clean up error handling when orphan list is corrupted Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] MIPS: ath79: make bootconsole wait for both THRE and TEMT Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] Fix OpenSSH pty regression on close Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] QE-UART: add "fsl,t1040-ucc-uart" to of_device_id Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] thunderbolt: Fix double free of drom buffer Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] USB: serial: option: add support for Cinterion PH8 and AHxx Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] USB: leave LPM alone if possible when binding/unbinding interface drivers Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: misc: usbtest: format the data pattern according to max packet size Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] usb: misc: usbtest: fix pattern tests for scatterlists Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] mcb: Fixed bar number assignment for the gdd Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] USB: serial: option: add more ZTE device ids Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] USB: serial: option: add even " Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ACPI / osi: Fix an issue that acpi_osi=!* cannot disable ACPICA internal strings Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] USB: cp210x: relocate private data from USB interface to port Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] USB: serial: cp210x: fix hardware flow-control disable Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ext4: fix oops on corrupted filesystem Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ext4: address UBSAN warning in mb_find_order_for_block() Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] ext4: silence UBSAN in ext4_mb_init() Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] arm64: Ensure pmd_present() returns false after pmd_mknotpresent() Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] can: fix handling of unmodifiable configuration options Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] MIPS: Fix siginfo.h to use strict posix types Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] MIPS: Don't unwind to user mode with EVA Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] MIPS: Avoid using unwind_stack() with usermode Sasha Levin
2016-06-03 21:35 ` [added to the 4.1 stable tree] MIPS: Reserve nosave data for hibernation Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS64: R6: R2 emulation bugfix Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] usb: host: xhci-rcar: Use ARCH_RENESAS Sasha Levin
2016-06-04 0:47 ` Simon Horman
2016-06-04 1:14 ` Sasha Levin
2016-06-06 0:39 ` Simon Horman
2016-06-03 21:36 ` [added to the 4.1 stable tree] usb: xhci: make USB_XHCI_PLATFORM selectable Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] usb: host: xhci-rcar: Avoid long wait in xhci_reset() Sasha Levin
2016-06-06 9:28 ` Yoshihiro Shimoda
2016-06-06 18:19 ` Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] mfd: omap-usb-tll: Fix scheduling while atomic BUG Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] USB: serial: io_edgeport: fix memory leaks in attach error path Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] USB: serial: io_edgeport: fix memory leaks in probe " Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] USB: serial: keyspan: fix use-after-free " Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] USB: serial: mxuport: " Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] USB: serial: quatech2: " Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] crypto: caam - fix caam_jr_alloc() ret code Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: KVM: Fix timer IRQ race when freezing timer Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: KVM: Fix timer IRQ race when writing CP0_Compare Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] gcov: disable tree-loop-im to reduce stack usage Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] irqchip/gic: Ensure ordering between read of INTACK and shared data Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] irqchip/gic-v3: Configure all interrupts as non-secure Group-1 Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] kbuild: move -Wunused-const-variable to W=1 warning level Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] rtlwifi: Fix logic error in enter/exit power-save mode Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] sched/loadavg: Fix loadavg artifacts on fully idle and on fully loaded systems Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] powerpc/eeh: Don't report error in eeh_pe_reset_and_recover() Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] powerpc/eeh: Restore initial state " Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] Revert "powerpc/eeh: Fix crash in eeh_add_device_early() on Cell" Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] powerpc/iommu: Remove the dependency on EEH struct in DDW mechanism Sasha Levin
2016-06-04 2:33 ` Guilherme G. Piccoli
[not found] ` <201606040233.u542T0jY033418@mx0a-001b2d01.pphosted.com>
2016-06-04 2:52 ` Sasha Levin [this message]
2016-06-04 2:54 ` Guilherme G. Piccoli
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: Handle highmem pages in __update_cache Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: Sync icache & dcache in set_pte_at Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] SIGNAL: Move generic copy_siginfo() to signal.h Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: Fix uapi include in exported asm/siginfo.h Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: math-emu: Fix jalr emulation when rd == $0 Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: ptrace: Fix FP context restoration FCSR regression Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: ptrace: Prevent writes to read-only FCSR bits Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: Disable preemption during prctl(PR_SET_FP_MODE, ...) Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ring-buffer: Add unlikelys to make fast path the default Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ring-buffer: Move recursive check to per_cpu descriptor Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ring-buffer: Use long for nr_pages to avoid overflow failures Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ring-buffer: Prevent overflow of size in ring_buffer_resize() Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] mmc: mmc: Fix partition switch timeout for some eMMCs Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] PCI: Disable all BAR sizing for devices with non-compliant BARs Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] MIPS: MSA: Fix a link error on `_init_msa_upper' with older GCC Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] drm/i915/fbdev: Fix num_connector references in intel_fb_initial_config() Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] drm/fb_helper: Fix references to dev->mode_config.num_connector Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] fs/cifs: correctly to anonymous authentication via NTLMSSP Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] fs/cifs: correctly to anonymous authentication for the LANMAN authentication Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] fs/cifs: correctly to anonymous authentication for the NTLM(v1) authentication Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] fs/cifs: correctly to anonymous authentication for the NTLM(v2) authentication Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] remove directory incorrectly tries to set delete on close on non-empty directories Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] cpuidle/coupled: Remove redundant 'dev' argument of cpuidle_state_is_coupled() Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] cpuidle: Fix cpuidle_state_is_coupled() argument in cpuidle_enter() Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] xfs: xfs_iflush_cluster fails to abort on error Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] xfs: fix inode validity check in xfs_iflush_cluster Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] xfs: skip stale inodes " Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ASoC: ak4642: Fix up max_register setting Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ASoC: ak4642: Enable cache usage to fix crashes on resume Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] cifs: Create dedicated keyring for spnego operations Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ALSA: hda - Fix headphone mic input on a few Dell ALC293 machines Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] ALSA: hda - Fix headphone noise on Dell XPS 13 9360 Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] kvm: arm64: Fix EC field in inject_abt64 Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] Input: uinput - handle compat ioctl for UI_SET_PHYS Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] PM / sleep: Handle failures in device_suspend_late() consistently Sasha Levin
2016-06-03 21:36 ` [added to the 4.1 stable tree] drm/i915: Don't leave old junk in ilk active watermarks on readout Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] mmc: longer timeout for long read time quirk Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] mmc: sdhci-acpi: Remove MMC_CAP_BUS_WIDTH_TEST for Intel controllers Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] sunrpc: fix stripping of padded MIC tokens Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] wait/ptrace: assume __WALL if the child is traced Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] xen/x86: actually allocate legacy interrupts on PV guests Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] xen/events: Don't move disabled irqs Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] UBI: Fix static volume checks when Fastmap is used Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] dma-debug: avoid spinlock recursion when disabling dma-debug Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] Input: pwm-beeper - fix - scheduling while atomic Sasha Levin
2016-06-03 21:37 ` [added to the 4.1 stable tree] hpfs: fix remount failure when there are no options changed Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57524280.2030606@oracle.com \
--to=sasha.levin@oracle.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).