From: "Nicolai Hähnle" <nhaehnle@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, stable@vger.kernel.org
Subject: Re: [amd-gfx] [PATCH] drm/amdgpu: fix num_rbs exposed to userspace (v2)
Date: Fri, 17 Jun 2016 20:11:59 +0200 [thread overview]
Message-ID: <57643D6F.2050608@gmail.com> (raw)
In-Reply-To: <1466185923-7359-1-git-send-email-alexander.deucher@amd.com>
LGTM.
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
On 17.06.2016 19:52, Alex Deucher wrote:
> This was accidently broken for harvest cards when the
> code was refactored for Polaris support.
>
> v2: multiply by shader engines. Noticed by Nicolai.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 40a2370..d851ea1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -447,7 +447,8 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
> dev_info.max_memory_clock = adev->pm.default_mclk * 10;
> }
> dev_info.enabled_rb_pipes_mask = adev->gfx.config.backend_enable_mask;
> - dev_info.num_rb_pipes = adev->gfx.config.num_rbs;
> + dev_info.num_rb_pipes = adev->gfx.config.max_backends_per_se *
> + adev->gfx.config.max_shader_engines;
> dev_info.num_hw_gfx_contexts = adev->gfx.config.max_hw_contexts;
> dev_info._pad = 0;
> dev_info.ids_flags = 0;
>
prev parent reply other threads:[~2016-06-17 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 17:52 [PATCH] drm/amdgpu: fix num_rbs exposed to userspace (v2) Alex Deucher
2016-06-17 18:11 ` Nicolai Hähnle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57643D6F.2050608@gmail.com \
--to=nhaehnle@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).