From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx193.ext.ti.com ([198.47.27.77]:40256 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdKUKXc (ORCPT ); Tue, 21 Nov 2017 05:23:32 -0500 Subject: Re: [PATCH v2] omapdrm: hdmi4: Correct the SoC revision matching To: Peter Ujfalusi , , CC: , , , References: <20171120095140.12969-1-peter.ujfalusi@ti.com> From: Tomi Valkeinen Message-ID: <576529aa-3d9d-bc0a-0b05-9f72940d40f8@ti.com> Date: Tue, 21 Nov 2017 12:23:24 +0200 MIME-Version: 1.0 In-Reply-To: <20171120095140.12969-1-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 20/11/17 11:51, Peter Ujfalusi wrote: > I believe the intention of the commit 2c9fc9bf45f8 > ("drm: omapdrm: Move FEAT_HDMI_* features to hdmi4 driver") > was to identify omap4430 ES1.x, omap4430 ES2.x and other OMAP4 revisions, > like omap4460. > > By using family=OMAP4 in the match the code will treat omap4460 ES1.x in a > same way as it would treat omap4430 ES1.x > > This breaks HDMI audio on OMAP4460 devices (PandaES for example). > > Correct the match rule so we are not going to get false positive match. > > Fixes: 2c9fc9bf45f8 ("drm: omapdrm: Move FEAT_HDMI_* features to hdmi4 driver") > > CC: stable@vger.kernel.org # 4.14 > Signed-off-by: Peter Ujfalusi Thanks, I have picked this up. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki