From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:38106 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbcFVEMl (ORCPT ); Wed, 22 Jun 2016 00:12:41 -0400 Subject: Re: [PATCH] xen/pciback: Fix conf_space read/write overlap check. To: Boris Ostrovsky , Andrey Grodzovsky , xen-devel@lists.xenproject.org References: <1466519876-7205-1-git-send-email-andrey2805@gmail.com> <576962A2.9080000@oracle.com> Cc: jw@quattru.com, Jan Beulich , stable@vger.kernel.org, David Vrabel , Linux Kernel Mailing List From: Juergen Gross Message-ID: <576A1004.3000301@suse.com> Date: Wed, 22 Jun 2016 06:11:48 +0200 MIME-Version: 1.0 In-Reply-To: <576962A2.9080000@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 21/06/16 17:52, Boris Ostrovsky wrote: > On 06/21/2016 10:37 AM, Andrey Grodzovsky wrote: >> Current overlap check is evaluating to false a case where a filter field >> is fully contained (proper subset) of a r/w request. >> This change applies classical overlap check instead to include >> all the scenarios. >> >> Related to https://www.mail-archive.com/xen-devel@lists.xen.org/msg72174.html >> >> Cc: Jan Beulich >> Cc: Boris Ostrovsky >> Cc: stable@vger.kernel.org >> Signed-off-by: Andrey Grodzovsky > > + David and Juergen (maintainers) and kernel list. > > Reviewed-by: Boris Ostrovsky Acked-by: Juergen Gross > > >> --- >> drivers/xen/xen-pciback/conf_space.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/xen/xen-pciback/conf_space.c b/drivers/xen/xen-pciback/conf_space.c >> index 8e67336..6a25533 100644 >> --- a/drivers/xen/xen-pciback/conf_space.c >> +++ b/drivers/xen/xen-pciback/conf_space.c >> @@ -183,8 +183,7 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size, >> field_start = OFFSET(cfg_entry); >> field_end = OFFSET(cfg_entry) + field->size; >> >> - if ((req_start >= field_start && req_start < field_end) >> - || (req_end > field_start && req_end <= field_end)) { >> + if (req_end > field_start && field_end > req_start) { >> err = conf_space_read(dev, cfg_entry, field_start, >> &tmp_val); >> if (err) >> @@ -230,8 +229,7 @@ int xen_pcibk_config_write(struct pci_dev *dev, int offset, int size, u32 value) >> field_start = OFFSET(cfg_entry); >> field_end = OFFSET(cfg_entry) + field->size; >> >> - if ((req_start >= field_start && req_start < field_end) >> - || (req_end > field_start && req_end <= field_end)) { >> + if (req_end > field_start && field_end > req_start) { >> tmp_val = 0; >> >> err = xen_pcibk_config_read(dev, field_start, > > >