From: Zefan Li <lizefan@huawei.com>
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
Tejun Heo <tj@kernel.org>
Cc: Rik van Riel <riel@redhat.com>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
<stable@vger.kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Juri Lelli <juri.lelli@arm.com>,
Steven Rostedt <rostedt@goodmis.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] cgroup: Disable IRQs while holding css_set_lock
Date: Thu, 23 Jun 2016 09:05:07 +0800 [thread overview]
Message-ID: <576B35C3.8070109@huawei.com> (raw)
In-Reply-To: <1466627321-22137-1-git-send-email-bristot@redhat.com>
On 2016/6/23 4:28, Daniel Bristot de Oliveira wrote:
> While testing the deadline scheduler + cgroup setup I hit this
> warning.
>
...
> The warn is the spin_(lock|unlock)_bh(&css_set_lock) in the interrupt
> context. Converting the spin_lock_bh to spin_lock_irq(save) to avoid
> this problem - and other problems of sharing a spinlock with an
> interrupt.
>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Juri Lelli <juri.lelli@arm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: cgroups@vger.kernel.org
> Cc: stable@vger.kernel.org # 4.5+
> Cc: linux-kernel@vger.kernel.org
> Reviewed-by: Rik van Riel <riel@redhat.com>
> Reviewed-by: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
>
Acked-by: Zefan Li <lizefan@huawei.com>
next prev parent reply other threads:[~2016-06-23 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 20:28 [PATCH v3] cgroup: Disable IRQs while holding css_set_lock Daniel Bristot de Oliveira
2016-06-23 1:05 ` Zefan Li [this message]
2016-06-23 21:20 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576B35C3.8070109@huawei.com \
--to=lizefan@huawei.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@arm.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).